Fix generic dots params type check

Author: CppCXY

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 # 0.6.0 (unreleased)
 
+# 0.5.4
+
+`Fix` Fix generic dots params type check
 
 # 0.5.3 
 

Cargo.toml

@@ -8,7 +8,7 @@ members = [
 [workspace.dependencies]
 # local
 emmylua_code_analysis = { path = "crates/emmylua_code_analysis", version = "0.5.0" }
-emmylua_parser = { path = "crates/emmylua_parser", version = "0.10.0" }
+emmylua_parser = { path = "crates/emmylua_parser", version = "0.10.1" }
 emmylua_diagnostic_macro = { path = "crates/emmylua_diagnostic_macro", version = "0.4.0" }
 
 # external

crates/emmylua_code_analysis/src/diagnostic/test/param_type_check_test.rs

@@ -284,4 +284,16 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_generic_dots_param() {
+        let mut ws = VirtualWorkspace::new_with_init_std_lib();
+
+        assert!(ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+            local d = select(1, 1, 2, 3)
+        "#
+        ));
+    }
 }

crates/emmylua_code_analysis/src/semantic/instantiate/instantiate_class_generic.rs

@@ -111,7 +111,12 @@ pub fn instantiate_doc_function(
                                     new_params.push(param.clone());
                                 }
                             }
-                            _ => {}
+                            _ => {
+                                new_params.push((
+                                    "...".to_string(),
+                                    Some(LuaType::Variadic(LuaType::Any.into())),
+                                ));
+                            }
                         }
                     }
                 }

crates/emmylua_code_analysis/src/semantic/type_check/simple_type.rs

@@ -11,6 +11,7 @@ pub fn check_simple_type_compact(
     check_guard: TypeCheckGuard,
 ) -> TypeCheckResult {
     match source {
+        LuaType::Unknown | LuaType::Any => return Ok(()),
         LuaType::Nil => {
             if let LuaType::Nil = compact_type {
                 return Ok(());
@@ -156,6 +157,13 @@ pub fn check_simple_type_compact(
                     compact_type,
                     check_guard.next_level()?,
                 );
+            } else {
+                return check_simple_type_compact(
+                    db,
+                    source_type,
+                    compact_type,
+                    check_guard.next_level()?,
+                );
             }
         }
         _ => {}