optimize for range for tuple

Author: CppCXY

crates/emmylua_code_analysis/src/db_index/type/type_ops/union_type.rs

@@ -47,6 +47,7 @@ pub fn union_type(source: LuaType, target: LuaType) -> LuaType {
                 .iter()
                 .map(|it| it.clone())
                 .collect::<Vec<_>>();
+            types.dedup();
             types.push(right.clone());
 
             LuaType::Union(LuaUnionType::new(types).into())

crates/emmylua_code_analysis/src/db_index/type/types.rs

@@ -410,16 +410,19 @@ impl LuaTupleType {
     pub fn cast_down_array_base(&self) -> LuaType {
         let mut ty = LuaType::Unknown;
         for t in &self.types {
-            if t.is_integer() {
-                ty = TypeOps::Union.apply(&ty, &LuaType::Integer);
-            } else if t.is_number() {
-                ty = TypeOps::Union.apply(&ty, &LuaType::Number);
-            } else if t.is_string() {
-                ty = TypeOps::Union.apply(&ty, &LuaType::String);
-            } else if t.is_boolean() {
-                ty = TypeOps::Union.apply(&ty, &LuaType::Boolean);
-            } else {
-                ty = TypeOps::Union.apply(&ty, &t);
+            match t {
+                LuaType::IntegerConst(i) => {
+                    ty = TypeOps::Union.apply(&ty, &LuaType::DocIntegerConst(*i));
+                }
+                LuaType::FloatConst(_) => {
+                    ty = TypeOps::Union.apply(&ty, &LuaType::Number);
+                }
+                LuaType::StringConst(s) => {
+                    ty = TypeOps::Union.apply(&ty, &LuaType::DocStringConst(s.clone()));
+                }
+                _ => {
+                    ty = TypeOps::Union.apply(&ty, t);
+                }
             }
         }
 

crates/emmylua_code_analysis/src/diagnostic/test/param_type_check_test.rs

@@ -189,4 +189,21 @@ mod test {
         "#
         ));
     }
+
+    #[test]
+    fn test_issue_102() {
+        let mut ws = VirtualWorkspace::new_with_init_std_lib();
+
+        assert!(ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+        ---@param _kind '' | 'Nr' | 'Ln' | 'Cul'
+        function foo(_kind) end
+
+        for _, kind in ipairs({ '', 'Nr', 'Ln', 'Cul' }) do
+            foo(kind)
+        end
+        "#
+        ));
+    }
 }