add clippy as lint

Author: CppCXY

.clippy.toml

@@ -0,0 +1,4 @@
+# Clippy thresholds for EmmyLua Analyzer (parser/compiler project)
+cognitive-complexity-threshold = 50
+type-complexity-threshold = 150
+too-many-arguments-threshold = 12

.github/workflows/test.yml

@@ -37,6 +37,19 @@ jobs:
     - name: Run style check
       run: pre-commit run --all
 
+  clippy:
+    name: Clippy Lint Check
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+    - name: Install Rust toolchain with clippy
+      uses: dtolnay/rust-toolchain@stable
+      with:
+        components: clippy
+    - name: Run Clippy
+      run: cargo clippy --workspace --all-targets --all-features -- -D warnings
+
   test:
     runs-on: ubuntu-latest
     steps:

Cargo.toml

@@ -53,3 +53,67 @@ num-traits = { version = "0.2", features = ["std"] }
 mimalloc = "0.1.47"
 googletest = "0.14.2"
 unicode-general-category = "1.0.0"
+
+# Lint configuration for the entire workspace
+[workspace.lints.clippy]
+# ==== Domain-Specific Allowances ====
+# These patterns are acceptable/necessary in parser/language-server projects
+
+# Module inception is acceptable for AST/syntax organization
+module_inception = "allow"
+
+# Enum variant name repetition is necessary for syntax tree clarity
+enum_variant_names = "allow"
+
+# Parser methods often have domain-specific naming conventions
+wrong_self_convention = "allow"
+
+# Box collections are sometimes needed for complex recursive structures
+box_collection = "allow"
+
+# Parser constants shouldn't be confused with mathematical constants
+approx_constant = "allow"
+
+# Complex cognitive complexity is acceptable for domain-specific logic
+cognitive_complexity = "allow"
+
+# High type complexity threshold for domain modeling (see .clippy.toml for thresholds)
+type_complexity = "allow"
+
+# Allow many arguments for builder patterns and comprehensive APIs
+too_many_arguments = "allow"
+
+# ==== General Code Quality Allowances ====
+# Let-and-return is sometimes more readable for debugging
+let_and_return = "allow"
+
+# Needless borrow warnings in test code are often false positives
+needless_borrow = "allow"
+
+# Single component path imports are sometimes necessary
+single_component_path_imports = "allow"
+
+# Bool assertion comparisons are explicit and readable
+bool_assert_comparison = "allow"
+
+# Let unit value can be useful for side effects
+let_unit_value = "allow"
+
+# Clone on copy can be more explicit about intent
+clone_on_copy = "allow"
+
+# Collapsible if/match statements are sometimes more readable when separate
+collapsible_if = "allow"
+collapsible_match = "allow"
+
+# Some functions need a Default implementation pattern without Default trait
+new_without_default = "allow"
+
+# Manual implementations can be more explicit than derive
+manual_let_else = "allow"
+
+# ==== Documentation Lints ====
+# Allow missing docs for internal/test functions
+missing_errors_doc = "allow"
+missing_panics_doc = "allow"
+undocumented_unsafe_blocks = "allow"

crates/emmylua_check/src/init.rs

@@ -163,10 +163,10 @@ pub fn collect_files(
     files
 }
 
-pub fn calculate_include_and_exclude(
-    emmyrc: &Emmyrc,
-    ignore: Option<Vec<String>>,
-) -> (Vec<String>, Vec<String>, Vec<PathBuf>) {
+/// File patterns for workspace scanning: (include_patterns, exclude_patterns, exclude_dirs)
+type FilePatterns = (Vec<String>, Vec<String>, Vec<PathBuf>);
+
+pub fn calculate_include_and_exclude(emmyrc: &Emmyrc, ignore: Option<Vec<String>>) -> FilePatterns {
     let mut include = vec!["**/*.lua".to_string(), "**/.editorconfig".to_string()];
     let mut exclude = Vec::new();
     let mut exclude_dirs = Vec::new();

crates/emmylua_check/src/output/mod.rs

@@ -12,11 +12,14 @@ use crate::cmd_args::{OutputDestination, OutputFormat};
 
 use crate::terminal_display::TerminalDisplay;
 
+/// Type alias for diagnostic result channel
+type DiagnosticReceiver = Receiver<(FileId, Option<Vec<Diagnostic>>)>;
+
 pub async fn output_result(
     total_count: usize,
     db: &DbIndex,
     workspace: PathBuf,
-    mut receiver: Receiver<(FileId, Option<Vec<Diagnostic>>)>,
+    mut receiver: DiagnosticReceiver,
     output_format: OutputFormat,
     output: OutputDestination,
     warnings_as_errors: bool,

crates/emmylua_code_analysis/Cargo.toml

@@ -15,6 +15,10 @@ include = [
     "resources/**",
 ]
 
+# Inherit workspace lints configuration
+[lints]
+workspace = true
+
 [dependencies]
 # local
 emmylua_parser.workspace = true

crates/emmylua_doc_cli/src/init.rs

@@ -164,10 +164,10 @@ pub fn collect_files(
     files
 }
 
-pub fn calculate_include_and_exclude(
-    emmyrc: &Emmyrc,
-    ignore: Option<Vec<String>>,
-) -> (Vec<String>, Vec<String>, Vec<PathBuf>) {
+/// File patterns for workspace scanning: (include_patterns, exclude_patterns, exclude_dirs)
+type FilePatterns = (Vec<String>, Vec<String>, Vec<PathBuf>);
+
+pub fn calculate_include_and_exclude(emmyrc: &Emmyrc, ignore: Option<Vec<String>>) -> FilePatterns {
     let mut include = vec!["**/*.lua".to_string(), "**/.editorconfig".to_string()];
     let mut exclude = Vec::new();
     let mut exclude_dirs = Vec::new();

crates/emmylua_ls/Cargo.toml

@@ -10,6 +10,10 @@ readme = "README.md"
 keywords = ["emmylua", "doc", "lua"]
 categories = ["development-tools"]
 
+# Inherit workspace lints configuration
+[lints]
+workspace = true
+
 [dependencies]
 # local
 emmylua_code_analysis.workspace = true

crates/emmylua_parser/Cargo.toml

@@ -10,6 +10,10 @@ readme = "README.md"
 keywords = ["emmylua", "luals", "parser", "lua"]
 categories = ["development-tools", "parsing"]
 
+# Inherit workspace lints configuration
+[lints]
+workspace = true
+
 [dependencies]
 rowan.workspace = true
 rust-i18n.workspace = true

crates/emmylua_parser_desc/Cargo.toml

@@ -10,6 +10,10 @@ readme = "README.md"
 keywords = ["emmylua", "luals", "parser", "lua"]
 categories = ["development-tools", "parsing"]
 
+# Inherit workspace lints configuration
+[lints]
+workspace = true
+
 [dependencies]
 # local
 emmylua_parser.workspace = true