optimize code

Author: CppCXY

crates/code_analysis/src/compilation/analyzer/decl/exprs.rs

@@ -2,7 +2,6 @@ use emmylua_parser::{
     LuaAstNode, LuaAstToken, LuaClosureExpr, LuaIndexExpr, LuaIndexKey, LuaLiteralExpr,
     LuaLiteralToken, LuaNameExpr, LuaTableExpr,
 };
-use internment::ArcIntern;
 
 use crate::{
     db_index::{LuaDecl, LuaMember, LuaMemberKey, LuaMemberOwner},
@@ -175,7 +174,7 @@ pub fn analyze_literal_expr(analyzer: &mut DeclAnalyzer, expr: LuaLiteralExpr) -
 
         analyzer.db.get_reference_index_mut().add_string_reference(
             file_id,
-            ArcIntern::new(value),
+            &value,
             string_token.get_range(),
         );
     }

crates/code_analysis/src/db_index/reference/mod.rs

@@ -4,7 +4,6 @@ mod string_reference;
 use std::collections::{HashMap, HashSet};
 
 use emmylua_parser::{LuaSyntaxId, LuaSyntaxKind};
-use internment::ArcIntern;
 use local_reference::LocalReference;
 use rowan::TextRange;
 use smol_str::SmolStr;
@@ -61,12 +60,7 @@ impl LuaReferenceIndex {
             .insert(syntax_id);
     }
 
-    pub fn add_string_reference(
-        &mut self,
-        file_id: FileId,
-        string: ArcIntern<String>,
-        range: TextRange,
-    ) {
+    pub fn add_string_reference(&mut self, file_id: FileId, string: &str, range: TextRange) {
         self.string_references
             .entry(file_id)
             .or_insert_with(StringReference::new)
@@ -169,13 +163,12 @@ impl LuaReferenceIndex {
     }
 
     pub fn get_string_references(&self, string_value: &str) -> Vec<InFiled<TextRange>> {
-        let arc_string = ArcIntern::new(string_value.to_string());
         let results = self
             .string_references
             .iter()
             .map(|(file_id, string_reference)| {
                 string_reference
-                    .get_string_references(&arc_string)
+                    .get_string_references(&string_value)
                     .into_iter()
                     .map(|range| InFiled::new(*file_id, range))
             })

crates/code_analysis/src/db_index/reference/string_reference.rs

@@ -1,10 +1,10 @@
-use internment::ArcIntern;
 use rowan::TextRange;
+use smol_str::SmolStr;
 use std::collections::HashMap;
 
 #[derive(Debug)]
 pub struct StringReference {
-    string_references: HashMap<ArcIntern<String>, Vec<TextRange>>,
+    string_references: HashMap<SmolStr, Vec<TextRange>>,
 }
 
 impl StringReference {
@@ -14,14 +14,14 @@ impl StringReference {
         }
     }
 
-    pub fn add_string_reference(&mut self, string: ArcIntern<String>, range: TextRange) {
+    pub fn add_string_reference(&mut self, string: &str, range: TextRange) {
         self.string_references
-            .entry(string)
+            .entry(SmolStr::new(string))
             .or_insert_with(Vec::new)
             .push(range);
     }
 
-    pub fn get_string_references(&self, string: &ArcIntern<String>) -> Vec<TextRange> {
+    pub fn get_string_references(&self, string: &str) -> Vec<TextRange> {
         self.string_references
             .get(string)
             .cloned()