refactor diagnostic system

Author: CppCXY

Cargo.lock

@@ -98,7 +98,6 @@ pub fn infer_type(analyzer: &mut DocAnalyzer, node: LuaDocType) -> LuaType {
         }
         _ => {} // LuaDocType::Conditional(lua_doc_conditional_type) => todo!(),
                 // LuaDocType::Variadic(lua_doc_variadic_type) => todo!(),
-                // LuaDocType::StrTpl(lua_doc_str_tpl_type) => todo!(),
     }
     LuaType::Unknown
 }

crates/code_analysis/src/compilation/analyzer/doc/infer_type.rs

@@ -3,9 +3,9 @@ use crate::DiagnosticCode;
 use super::{DiagnosticContext, LuaChecker};
 
 #[derive(Debug)]
-pub struct DuplicateTypeChecker();
+pub struct Checker();
 
-impl LuaChecker for DuplicateTypeChecker {
+impl LuaChecker for Checker {
     fn check(&self, context: &mut DiagnosticContext) -> Option<()> {
         let errors = {
             let db = context.get_db();
@@ -14,7 +14,7 @@ impl LuaChecker for DuplicateTypeChecker {
             let errors = diagnostic_index.get_diagnostics(file_id)?;
             let mut analyze_errs = Vec::new();
             for error in errors {
-                if error.kind == DiagnosticCode::DuplicateType {
+                if error.kind == self.get_code() {
                     analyze_errs.push((error.message.clone(), error.range.clone()));
                 }
             }

crates/code_analysis/src/diagnostic/checker/duplicate_type.rs

@@ -16,11 +16,17 @@ pub trait LuaChecker: Debug + Send + Sync {
     fn get_code(&self) -> DiagnosticCode;
 }
 
+macro_rules! checker {
+    ($name:ident) => {
+        Box::new($name::Checker())
+    };
+}
+
 pub fn init_checkers() -> Vec<Box<dyn LuaChecker>> {
     vec![
-        Box::new(syntax_error::SyntaxErrorChecker()),
-        Box::new(type_not_found::TypeNotFoundChecker()),
-        Box::new(duplicate_type::DuplicateTypeChecker()),
+        checker!(syntax_error),
+        checker!(type_not_found),
+        checker!(duplicate_type),
     ]
 }
 

crates/code_analysis/src/diagnostic/checker/mod.rs

@@ -3,9 +3,9 @@ use crate::DiagnosticCode;
 use super::{DiagnosticContext, LuaChecker};
 
 #[derive(Debug)]
-pub struct SyntaxErrorChecker();
+pub struct Checker();
 
-impl LuaChecker for SyntaxErrorChecker {
+impl LuaChecker for Checker {
     fn check(&self, context: &mut DiagnosticContext) -> Option<()> {
         let semantic_model = &context.semantic_model;
         if let Some(parse_errors) = semantic_model.get_file_parse_error() {

crates/code_analysis/src/diagnostic/checker/syntax_error.rs

@@ -3,9 +3,9 @@ use crate::DiagnosticCode;
 use super::{DiagnosticContext, LuaChecker};
 
 #[derive(Debug)]
-pub struct TypeNotFoundChecker();
+pub struct Checker();
 
-impl LuaChecker for TypeNotFoundChecker {
+impl LuaChecker for Checker {
     fn check(&self, context: &mut DiagnosticContext) -> Option<()> {
         let errors = {
             let db = context.get_db();

crates/code_analysis/src/diagnostic/checker/type_not_found.rs

@@ -1,6 +1,6 @@
 [package]
 name = "emmylua_ls"
-version = "0.1.0"
+version = "0.1.3"
 edition = "2021"
 
 [dependencies]
@@ -20,4 +20,4 @@ notify.workspace = true
 tokio-util.workspace = true
 rowan.workspace = true
 emmylua_codestyle.workspace = true
-walkdir.workspace = true
+walkdir.workspace = true