support read config file with utf8-bom

Author: CppCXY

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 # 0.7.2 (unreleased)
 
+`FIX` Fix reading configuration file encoded with UTF-8 BOM
+
 # 0.7.1
 
 `NEW` Now language server configuration might be provided globally via the `<os-specific home dir>/.emmyrc.json`, `<os-specific config dir>/emmylua_ls/.emmyrc.json`, or by setting a variable `EMMYLUALS_CONFIG` with a path to the json configuration.

crates/emmylua_code_analysis/src/config/config_loader.rs

@@ -2,22 +2,26 @@ use std::{collections::HashSet, path::PathBuf};
 
 use serde_json::Value;
 
+use crate::read_file_with_encoding;
+
 use super::{flatten_config::FlattenConfigObject, Emmyrc};
 
 pub fn load_configs(config_files: Vec<PathBuf>, partial_emmyrcs: Option<Vec<Value>>) -> Emmyrc {
     let mut config_jsons = Vec::new();
+
     for config_file in config_files {
-        let config_json_str = match std::fs::read_to_string(&config_file) {
-            Ok(json_str) => json_str,
-            Err(e) => {
+        log::info!("Loading config file: {:?}", config_file);
+        let config_json_str = match read_file_with_encoding(&config_file, "utf-8") {
+            Some(json_str) => json_str,
+            None => {
                 log::error!(
-                    "Failed to read config file: {:?}, error: {:?}",
-                    config_file,
-                    e
+                    "Failed to read config file: {:?}, error: File not found or unreadable",
+                    config_file
                 );
                 continue;
             }
         };
+
         let config_json: Value = match serde_json::from_str(&config_json_str) {
             Ok(json) => json,
             Err(e) => {

crates/emmylua_code_analysis/src/diagnostic/checker/unnecessary_if.rs

@@ -1,6 +1,6 @@
 use emmylua_parser::{LuaAstNode, LuaExpr, LuaIfStat};
 
-use crate::{DiagnosticCode, LuaType, SemanticModel};
+use crate::{DiagnosticCode, SemanticModel};
 
 use super::{Checker, DiagnosticContext};