Fix #634

Author: CppCXY

crates/emmylua_code_analysis/src/semantic/type_check/complex_type/table_generic_check.rs

@@ -68,9 +68,18 @@ pub fn check_table_generic_type_compact(
                 return Ok(());
             }
         }
+        LuaType::Userdata => return Ok(()),
         // maybe support object
         // need check later
-        LuaType::Ref(_) | LuaType::Def(_) | LuaType::Userdata => return Ok(()),
+        LuaType::Ref(id) | LuaType::Def(id) => {
+            let owner = LuaMemberOwner::Type(id.clone());
+            return check_table_generic_compact_member_owner(
+                db,
+                source_generic_param,
+                owner,
+                check_guard.next_level()?,
+            );
+        }
         LuaType::Union(union) => {
             for union_type in union.into_vec() {
                 check_table_generic_type_compact(

crates/emmylua_code_analysis/src/semantic/type_check/test.rs

@@ -1,6 +1,6 @@
 #[cfg(test)]
 mod test {
-    use crate::VirtualWorkspace;
+    use crate::{DiagnosticCode, VirtualWorkspace};
 
     #[test]
     fn test_string() {
@@ -150,4 +150,23 @@ mod test {
         let ty2 = ws.expr_ty("(\"hello\"):match(\".*\")");
         assert!(ws.check_type(&ty, &ty2));
     }
+
+    #[test]
+    fn test_issue_634() {
+        let mut ws = VirtualWorkspace::new();
+
+        assert!(!ws.check_code_for(
+            DiagnosticCode::ParamTypeNotMatch,
+            r#"
+            --- @class A
+            --- @field a integer
+
+            --- @param x table<integer,string>
+            local function foo(x) end
+
+            local y --- @type A
+            foo(y) -- should error
+        "#
+        ));
+    }
 }