standalone: mqtt adapter: handle publish command response errors

Author: rnovatorov

src/enapter/standalone/mqtt_adapter.py

@@ -105,7 +105,7 @@ async def _execute_commands(self) -> None:
                     tg.create_task(self._execute_command(request))
 
     async def _execute_command(self, request: mqtt.api.device.CommandRequest) -> None:
-        await self._device_channel.publish_command_response(
+        await self._publish_command_response(
             request.new_response(
                 mqtt.api.device.CommandState.LOG, {"message": "Executing command..."}
             )
@@ -115,20 +115,28 @@ async def _execute_command(self, request: mqtt.api.device.CommandRequest) -> Non
                 request.name, request.arguments
             )
         except NotImplementedError:
-            await self._device_channel.publish_command_response(
+            await self._publish_command_response(
                 request.new_response(
                     mqtt.api.device.CommandState.ERROR,
                     {"message": "Command handler not implemented."},
                 )
             )
         except Exception:
-            await self._device_channel.publish_command_response(
+            await self._publish_command_response(
                 request.new_response(
                     mqtt.api.device.CommandState.ERROR,
                     {"message": traceback.format_exc()},
                 )
             )
         else:
-            await self._device_channel.publish_command_response(
+            await self._publish_command_response(
                 request.new_response(mqtt.api.device.CommandState.COMPLETED, payload)
             )
+
+    async def _publish_command_response(
+        self, response: mqtt.api.device.CommandResponse
+    ) -> None:
+        try:
+            await self._device_channel.publish_command_response(response=response)
+        except Exception as e:
+            self._logger.error("failed to publish command response: %s", e)

tests/unit/test_standalone/test_mqtt_adapter.py

@@ -183,8 +183,10 @@ async def subscribe_to_command_requests():
         while True:
             yield await command_requests.get()
 
-    async def publish_command_response(r: enapter.mqtt.api.device.CommandResponse):
-        await command_responses.put(r)
+    async def publish_command_response(
+        response: enapter.mqtt.api.device.CommandResponse,
+    ):
+        await command_responses.put(response)
 
     device_channel.subscribe_to_command_requests = subscribe_to_command_requests
     device_channel.publish_command_response = publish_command_response
@@ -228,8 +230,10 @@ async def subscribe_to_command_requests():
         while True:
             yield await command_requests.get()
 
-    async def publish_command_response(r: enapter.mqtt.api.device.CommandResponse):
-        await command_responses.put(r)
+    async def publish_command_response(
+        response: enapter.mqtt.api.device.CommandResponse,
+    ):
+        await command_responses.put(response)
 
     device_channel.subscribe_to_command_requests = subscribe_to_command_requests
     device_channel.publish_command_response = publish_command_response
@@ -273,8 +277,10 @@ async def subscribe_to_command_requests():
         while True:
             yield await command_requests.get()
 
-    async def publish_command_response(r: enapter.mqtt.api.device.CommandResponse):
-        await command_responses.put(r)
+    async def publish_command_response(
+        response: enapter.mqtt.api.device.CommandResponse,
+    ):
+        await command_responses.put(response)
 
     device_channel.subscribe_to_command_requests = subscribe_to_command_requests
     device_channel.publish_command_response = publish_command_response