light fixes and hacked together ENHANCED_OPENS support

Author: solamint

Encore/src/RhythmEngine/ChartLoaders/BaseLoader.h

@@ -48,6 +48,11 @@ namespace Encore::RhythmEngine {
                 && event[1] <= MinMaxDiff[diff].second;
         }
 
+        [[nodiscard]] static bool IsInPitchRangeGB(int diff, const smf::MidiEvent &event) {
+            return event[1] >= GuitarMinMaxDiff[diff].first
+                && event[1] <= GuitarMinMaxDiff[diff].second;
+        }
+
         [[nodiscard]] static int GetEventLane(int diff, const smf::MidiEvent &event) {
             return event[1] - MinMaxDiff[diff].first;
         }

Encore/src/RhythmEngine/ChartLoaders/GuitarLoader.cpp

@@ -186,7 +186,7 @@ void Encore::RhythmEngine::GuitarLoader::GetNotes(smf::MidiEventList track) {
         // im tired boss
         CheckEvents(event);
         CheckModifiers(event);
-        if (IsInPitchRange(Difficulty, event) && event.isNoteOn()) {
+        if (IsInPitchRangeGB(Difficulty, event) && event.isNoteOn()) {
             if (chart[0].empty()) {
                 chart.BaseScore += BASE_SCORE_NOTE_POINT;
                 CreateNote(event);

Encore/src/RhythmEngine/Engine/BaseEngine.cpp

@@ -98,6 +98,8 @@ void Encore::RhythmEngine::BaseEngine::CheckMissedNotes(int Lane, double SongTim
 }
 void Encore::RhythmEngine::BaseEngine::HitNote(int lane) {
     int chordSize = std::popcount(chart->CurrentNoteIterators.at(lane)->Lane);
+    if (chordSize == 0) chordSize = 1;
+
     int startTick = chart->CurrentNoteIterators.at(lane)->StartTicks;
     double startTime = chart->CurrentNoteIterators.at(lane)->StartSeconds;
     Encore::EncoreLog(

Encore/src/RhythmEngine/NoteVector.h

@@ -22,6 +22,10 @@ inline std::vector<std::pair<int, int> > MinMaxDiff = {
     { 60, 64 }, { 72, 76 }, { 84, 88 }, { 96, 100 }
 };
 
+inline std::vector<std::pair<int, int> > GuitarMinMaxDiff = {
+    { 59, 64 }, { 71, 76 }, { 83, 88 }, { 95, 100 }
+};
+
 inline std::vector<std::pair<int, int> > LiftMinMaxDiff = {
     { 66, 69 }, { 78, 81 }, { 90, 93 }, { 102, 106 }
 };