Game Crashes when Switching Characters while Extended Crafting Window is open. #146
Description
How to reproduce:
Open Extended crafting window, and while it is open switch characters. When logging into new character the game now crashes.
Error message:
rx.exceptions.OnErrorNotImplementedException: Cannot read field "menu" because "this.ui.gui" is null at rx.internal.util.InternalObservableUtils$ErrorNotImplementedAction.call(InternalObservableUtils.java:374) at rx.internal.util.InternalObservableUtils$ErrorNotImplementedAction.call(InternalObservableUtils.java:371) at rx.internal.util.ActionSubscriber.onError(ActionSubscriber.java:44) at rx.observers.SafeSubscriber._onError(SafeSubscriber.java:157) at rx.observers.SafeSubscriber.onError(SafeSubscriber.java:120) at rx.exceptions.Exceptions.throwOrReport(Exceptions.java:204) at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:144) at rx.subjects.SubjectSubscriptionManager$SubjectObserver.onNext(SubjectSubscriptionManager.java:223) at rx.subjects.PublishSubject.onNext(PublishSubject.java:114) at haven.Config.setPlayerName(Config.java:461) at haven.Charlist$Charbox.lambda$new$0(Charlist.java:93) at haven.Button.click(Button.java:190) at haven.Button.mouseup(Button.java:248) at haven.Widget$MouseUpEvent.shandle(Widget.java:1053) at haven.Widget.handle(Widget.java:910) at haven.Widget$Event.dispatch(Widget.java:863) at haven.UI$PointerGrab.handle(UI.java:598) at haven.UI$PointerGrab.handle(UI.java:586) at haven.UI$Grab.check(UI.java:576) at haven.UI$Grab.access$700(UI.java:560) at haven.UI.dispatch(UI.java:651) at haven.UI.processMouseUp(UI.java:918) at haven.UI.mouseup(UI.java:913) at haven.UIPanel$Dispatcher.dispatch(UIPanel.java:80) at haven.GLPanel$Loop.run(GLPanel.java:367) at haven.JOGLPanel.run(JOGLPanel.java:246) at java.base/java.lang.Thread.run(Unknown Source) Caused by: java.lang.NullPointerException: Cannot read field "menu" because "this.ui.gui" is null at haven.CraftDBWnd.loadFavourites(CraftDBWnd.java:103) at rx.internal.util.ActionSubscriber.onNext(ActionSubscriber.java:39) at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:139) ... 20 more
Suggested solution:
When user clicks change character button it also closes all open windows, or wrap the craftDBWnd in a try catch