Skip to content

Commit 8495458

Browse files
authored
REC-67: build release on Debian 11 (#49)
Switched to a Debian 11 worker image so that we link against a glibc with a lower version. Disabled remote execution for the release workflow because the currently release binaries are linked against a higher version of glibc and don't run on Debian 11. Also some things are not wired up correctly. We can turn this back on after the next release. Added a "dry run" mode to the release workflow so it's easier to check if things are wired up correctly in the future. Bug: linear/REC-67
1 parent 4ef5060 commit 8495458

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

.github/workflows/release.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,27 @@ on:
2121
type: string
2222
description: Version of engflow_auth to release; must be a semver version string, starting with `v`
2323
required: true
24+
dry_run:
25+
type: boolean
26+
description: "Dry run: if checked, all artifacts are built, but no release is created."
27+
required: true
2428

2529
permissions:
2630
contents: write
2731

32+
env:
33+
# Recommended here: https://github.com/bazelbuild/bazelisk/issues/88#issuecomment-625178467
34+
BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
35+
DRY_RUN: ${{ inputs.dry_run }}
36+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
37+
2838
jobs:
2939
release:
3040
runs-on:
3141
- self-hosted
3242
- os=linux
3343
- arch=x64
34-
- "engflow-container-image=docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-ci/debian12-dind-x64@sha256:763903935682de148b4e09fe1d7ef3bbc4ec829d59c3f41cb9519984639eaa06"
44+
- "engflow-container-image=docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-ci/debian11-dind-x64@sha256:604855f1ecd6edad3f45f513ed0112b9e8e32589871133767a1a51944b07f487"
3545
- "engflow-pool=ci_sysbox_x64"
3646
- "engflow-runtime=sysbox-runc"
3747
- "engflow-runner-id=${{ github.repository_id }}_release_${{ github.run_id }}_${{ github.run_number }}_${{ github.run_attempt }}"
@@ -40,15 +50,7 @@ jobs:
4050
steps:
4151
- uses: actions/checkout@v4
4252

43-
- name: Log in
44-
run: infra/login.sh
45-
4653
- name: release
4754
if: success()
4855
run: |
4956
infra/release.sh "${{ inputs.version }}"
50-
env:
51-
GITHUB_TOKEN: ${{ github.token }}
52-
53-
- name: Log out
54-
run: infra/logout.sh

infra/release.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ echo "[START] Building artifacts"
8585
BUILD_RELEASE_VERSION="${RELEASE_VERSION}" \
8686
bazel build \
8787
--config=release \
88-
--config=engflow \
89-
--config=remote_linux_x64 \
9088
-- \
9189
//:release_artifacts
9290
echo "[FINISH] Building artifacts"
@@ -125,6 +123,10 @@ cp \
125123
echo "[FINISH] Staging artifacts"
126124

127125
# Create release
126+
if [[ "${DRY_RUN}" == true ]]; then
127+
echo "[SKIP] Creating release"
128+
exit 0
129+
fi
128130
echo "[START] Creating release"
129131
${GH_CLI} release create \
130132
"${RELEASE_VERSION}" \

0 commit comments

Comments
 (0)