Minor fixes to readme and fix Buck2 CI (#368)

- buck2 issues fix: Pin to specific release + remove attr from go
toolchain that was removed upstream
- MacOS test-matrix issue: Python requirements lock generation was
failing. Updated to latest version of python rules -> had to run
`REPIN=1 bazel run @maven//:pin` afterwards to re-generate files with
dependencies that need to be modified consistently with python rules
update.

Author: nlopezgi

MODULE.bazel

@@ -76,7 +76,7 @@ bazel_dep(
     repo_name = "com_google_googleapis",
 )
 
-bazel_dep(name = "rules_python", version = "0.33.2")
+bazel_dep(name = "rules_python", version = "1.0.0")
 
 PYTHON_VERSION = "3.12"
 python = use_extension("@rules_python//python/extensions:python.bzl", "python")

MODULE.bazel.lock

@@ -16,7 +16,7 @@ In the `platforms` cell we specify:
 In the `toolchains` cell we specify:
 
 * The c++ toolchain `root//toolchains:cxx_tools_info_toolchain` that is compatible with the remote execution environment.
-* The clang tools, `root//toolchains:path_clang_tools, which is used by the c++ toolchain, and specifies the tools installed in the Docker image.
+* The clang tools, `root//toolchains:path_clang_tools`, which is used by the c++ toolchain, and specifies the tools installed in the Docker image.
 * The remote test execution toolchain, `root//toolchains:remote_test_execution_toolchain`. This toolchain defines platform options in the form of `capabilities`. Critically these include the `container-image`.
 
 The main `BUCK` file defines:
@@ -38,9 +38,9 @@ cas_address          = <CLUSTER_NAME>.cluster.engflow.com
 http_headers         = <AUTH_HTTP_HEADERS>
  ```
 
- To obtain the value of `<AUTH_HTTP_HEADERS>`, log into https://<CLUSTER_NAME>.cluster.engflow.com/gettingstarted and obtain the value of `x-engflow-auth-token` in section `Method 2: JWT`, take note of this value. Then set `AUTH_HTTP_HEADERS` with the value `x-engflow-auth-method:jwt-v0,x-engflow-auth-token:<JWT_TOKEN_FROM_GETTINGSTARTED_PAGE>.
+To obtain the value of `<AUTH_HTTP_HEADERS>`, log into https://<CLUSTER_NAME>.cluster.engflow.com/gettingstarted and obtain the value of `x-engflow-auth-token` in section `Method 2: JWT`, take note of this value. Then set `AUTH_HTTP_HEADERS` with the value `x-engflow-auth-method:jwt-v0,x-engflow-auth-token:<JWT_TOKEN_FROM_GETTINGSTARTED_PAGE>.
 
- Note for CI runs, the auth method used is [Github Tokens](https://docs.engflow.com/re/config/authentication.html#github-tokens).
+Note for CI runs, the auth method used is [Github Tokens](https://docs.engflow.com/re/config/authentication.html#github-tokens).
 
 ### Usage instructions
 

buck2/cpp/README.md

@@ -22,7 +22,7 @@ In the `toolchains` cell we specify:
 
 The `main` cell and `library` cell:
 
-* Contains an copied version of https://github.com/facebook/buck2/tree/main/examples/with_prelude/go that works with Buck2 and RE as configured in this sample project.
+* Contains a copied version of https://github.com/facebook/buck2/tree/main/examples/with_prelude/go that works with Buck2 and RE as configured in this sample project.
 
 To test this cell with RE run (after setting up `.buckconfig` as indicated below):
 

buck2/golang/README.md

@@ -24,7 +24,7 @@ def _platforms(ctx):
     )
 
     # A bookworm image with go pre-installed.
-    # Unlike Bazel go_toolchain, Buck2 go_toolchain does not include a hermetic go binary.
+    # Unlike Bazel go_toolchain, Buck2 go_toolchain does not include a hermetic go binary. Image details can be found in https://gallery.ecr.aws/docker/library/golang.
     image = "docker://public.ecr.aws/docker/library/golang:1.23.3-bookworm@sha256:3f3b9daa3de608f3e869cd2ff8baf21555cf0fca9fd34251b8f340f9b7c30ec5"
     name = ctx.label.raw_target()
     platform = ExecutionPlatformInfo(

buck2/golang/platforms/defs.bzl

@@ -52,7 +52,7 @@ remote_test_execution_toolchain(
         "cxx_re_toolchain": {
             "use_case": "cxx-testing",
             "capabilities": {
-                "container-image" : "docker://gcr.io/bazel-public/ubuntu2004-java11@sha256:69a78f121230c6d5cbfe2f4af8ce65481aa3f2acaaaf8e899df335f1ac1b35b5",
+                "container-image" : "docker://public.ecr.aws/docker/library/golang:1.23.3-bookworm@sha256:3f3b9daa3de608f3e869cd2ff8baf21555cf0fca9fd34251b8f340f9b7c30ec5",
             },
         }
     },

buck2/golang/toolchains/BUCK

@@ -71,7 +71,6 @@ def _remote_go_toolchain_impl(ctx):
             go_wrapper = ctx.attrs.go_wrapper[RunInfo],
             linker = RunInfo(cmd_script(ctx, "link", cmd_args(go, "tool", "link"), script_os)),
             packer = RunInfo(cmd_script(ctx, "pack", cmd_args(go, "tool", "pack"), script_os)),
-            tags = [],
             linker_flags = [],
             assembler_flags = [],
             compiler_flags = [],

buck2/golang/toolchains/defs.bzl

@@ -1,8 +1,8 @@
 #!/usr/bin/env bash
 set -xe
 
-# Get the Buck2 binary.
-curl -L -O https://github.com/facebook/buck2/releases/download/latest/buck2-x86_64-unknown-linux-musl.zst
+# Get the Buck2 binary - pinned to https://github.com/facebook/buck2/releases/tag/2024-12-16
+curl -L -O https://github.com/facebook/buck2/releases/download/2024-12-16/buck2-x86_64-unknown-linux-musl.zst
 
 # Unpack the binary.
 unzstd buck2-x86_64-unknown-linux-musl.zst