CheckStyle: Update rule set

- Remove HideUtilityClassConstructor check. Fixing these violations would require adding ~104 empty private constructors to hide default constructors. This should not be forced upon contributors.
- Ignore MethodName check. Changing public method names will break any extensions that uses them. This should not be done without deprecating all violating methods first.
- Remove MissingCtor check. This would require adding ~1100 empty constructors to not directly rely on the default one. This should not be forced upon contributors and does not make the code more clear.
- Change whitespace check for "try", which now enforces whitespace usage "try(" and "try {".
- Disable "SuperClone" and "SuperFinalize" check. These checks even require to call super.clone() and super.finalize() when their class extends directly from Object, in which case adding them is pointless and at most distracting.
- Fix whitespace check for between if/for/while and their '('.

Author: Pieter12345

checkstyle.xml

@@ -63,9 +63,6 @@
 		<!-- Ensure proper whitespace usage around "<" and ">" for generic types -->
 		<module name="GenericWhitespace"/>
 
-		<!-- Ensure that classes with only static methods do not have a public constructor -->
-		<module name="HideUtilityClassConstructor"/>
-		
 		<!-- Disallow native literals -->
 		<module name="IllegalToken">
 			<property name="tokens" value="LITERAL_NATIVE"/>
@@ -86,17 +83,17 @@
 		<module name="MemberName"/>
 
 		<!-- Ensure method name format and disallow methods to be named the same as the class (and therefore constructor). Default format: "^[a-z][a-zA-Z0-9]*$" -->
-		<module name="MethodName"/>
+		<module name="MethodName">
+			<!-- TODO: Disable rule or fix violations with the chance to break extensions. There are 479 violations as of 14-06-2018 dd-mm-yyyy -->
+			<property name="severity" value="ignore"/>
+		</module>
 
 		<!-- Check method parameter padding -->
 		<module name="MethodParamPad"/>
 
 		<!-- Check method type name format. Default format: "^[A-Z]$" -->
 		<module name="MethodTypeParameterName"/>
 
-		<!-- Ensure that non-abstract classes define a constructor and not rely on the default one -->
-		<module name="MissingCtor"/>
-		
 		<!-- Ensure that both the @Deprecated and the @deprecated javadoc tag are present when one is present -->
 		<module name="MissingDeprecated"/>
 
@@ -137,7 +134,7 @@
 			<property name="allowEmptyCatches" value="true"/>
 			<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR,
 				BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAMBDA, LAND, LCURLY, LE, LITERAL_CATCH, LITERAL_DO,
-				LITERAL_ELSE, LITERAL_FINALLY, LITERAL_RETURN, LITERAL_TRY,
+				LITERAL_ELSE, LITERAL_FINALLY, LITERAL_RETURN,
 				LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION,
 				RCURLY, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND"/>
 		</module>
@@ -163,9 +160,6 @@
 		<!-- Disallow redundant (double or default-available class) imports -->
 		<module name="RedundantImport"/>
 
-		<!-- Require "this" for non-static field access -->
-		<module name="RequireThis"/>
-		
 		<!-- Ensure usage of "}" for the given tokens -->
 		<module name="RightCurly">
 			<property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE"/>
@@ -189,12 +183,6 @@
 		<!-- Disallow the "==" operator for string literals -->
 		<module name="StringLiteralEquality"/>
 
-		<!-- Ensure that an overriding clone() method invokes super.clone() -->
-		<module name="SuperClone"/>
-		
-		<!-- Ensure that an overriding finalize() method invokes super.finalize() -->
-		<module name="SuperFinalize"/>
-		
 		<!-- Disallow whitespaces between type cast parenthesis (No whitespace at X: "(XObjectX) obj") -->
 		<module name="TypecastParenPad"/>
 
@@ -219,10 +207,24 @@
 	<!-- Disallow whitespaces between if/for/while and '(' -->
 	<module name="RegexpSingleline">
 		<property name="severity" value="error"/>
-		<property name="format" value="(^|[^w\._])(if|for|while)[\s]+\("/>
+		<property name="format" value="(^|[^\w\._])(if|for|while)[\s]+\("/>
 		<property name="message" value="Whitespace between if/for/while and '(' is not allowed."/>
 	</module>
 
+	<!-- Ensure whitespace between try and '{' -->
+	<module name="RegexpSingleline">
+		<property name="severity" value="error"/>
+		<property name="format" value="(^|[^\w\._])try\{"/>
+		<property name="message" value="'try' is not followed by whitespace."/>
+	</module>
+	
+	<!-- Disallow whitespaces between try and '(' (try-with-resources) -->
+	<module name="RegexpSingleline">
+		<property name="severity" value="error"/>
+		<property name="format" value="(^|[^\w\._])try[\s]+\("/>
+		<property name="message" value="'try' with resources is followed by whitespace."/>
+	</module>
+	
 	<!-- Ensure that every file ends with a newline -->
 	<module name="NewlineAtEndOfFile"/>
 

checkstyle_suppressions.xml

@@ -9,4 +9,11 @@
 	<!-- Ignore type name check for package "com.laytonsmith.core.functions" since function classes use a different format -->
 	<suppress checks="TypeName" files="com[\\/]laytonsmith[\\/]core[\\/]functions.*\.java$"/>
 
+	<!-- Ignore local variable name check for package "com.laytonsmith.core.functions" since many variables are called after CH functions -->
+	<suppress checks="LocalVariableName" files="com[\\/]laytonsmith[\\/]core[\\/]functions.*\.java$"/>
+	
+	<!-- Ignore type name check for package "com.laytonsmith.core.events drivers" since event driver classes use a different format -->
+	<suppress checks="TypeName" files="com[\\/]laytonsmith[\\/]core[\\/]events[\\/]drivers.*\.java$"/>
+	
+	
 </suppressions>