Skip to content

Commit 7292c62

Browse files
committed
Move slf4j ban to checkstyle
1 parent 169b1a0 commit 7292c62

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

config/checkstyle/checkstyle-suppression.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
<suppress files=".*[\\/]test[\\/].*\.java" checks="package-info-NullMarked|JavadocPackage"/>
1010
<!-- Suppress ICs for now -->
1111
<suppress files=".*[\\/]mechanics[\\/]ic[\\/].*\.java" checks=".*"/>
12-
<!-- Suppress doctools -->
13-
<suppress files=".*[\\/]doctools[\\/].*\.java" checks=".*"/>
1412
<!-- Suppress legacy files -->
1513
<suppress files=".*[\\/]ItemUtil.java" checks=".*"/>
1614
<suppress files=".*[\\/]ICUtil.java" checks=".*"/>

config/checkstyle/checkstyle.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,10 @@ Checks based on Google Checks, modified for EngineHub.
145145
<property name="sortImportsInGroupAlphabetically" value="true"/>
146146
<property name="customImportOrderRules" value="THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE###STATIC"/>
147147
</module>
148+
<module name="IllegalImport">
149+
<property name="illegalPkgs" value="org.slf4j"/>
150+
<message key="name.invalidPattern" value="Illegal import - {0}. Use Log4J instead."/>
151+
</module>
148152
<module name="MethodParamPad"/>
149153
<module name="OperatorWrap">
150154
<property name="option" value="NL"/>

craftbook-bukkit/doctools/src/main/java/org/enginehub/craftbook/internal/util/CommandUtils.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,7 @@ private static String cmdsToPerms(List<Command> cmds, String prefix) {
140140
.stream()
141141
.sorted(Comparator.comparing(Command::getName))
142142
.toList(),
143-
prefix + c.getName() + " ")
144-
);
143+
prefix + c.getName() + " "));
145144
});
146145
return permsOutput.toString();
147146
}

0 commit comments

Comments
 (0)