Skip to content

Commit cb030de

Browse files
committed
Use the lines data from the returning event in SignCopier. Fixes #1364
1 parent 5ac877c commit cb030de

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/main/java/com/sk89q/craftbook/mechanics/signcopier/SignCopier.java

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,20 @@ public void onRightClick(SignClickEvent event) {
7171
Sign s = (Sign) event.getClickedBlock().getState();
7272
String[] lines = signs.get(player.getName());
7373

74-
CompatabilityUtil.disableInterferences(event.getPlayer());
75-
SignChangeEvent sev = new SignChangeEvent(event.getClickedBlock(), event.getPlayer(), lines);
76-
Bukkit.getPluginManager().callEvent(sev);
77-
78-
if(!sev.isCancelled()) {
79-
for(int i = 0; i < lines.length; i++)
80-
s.setLine(i, lines[i]);
81-
s.update();
74+
try {
75+
CompatabilityUtil.disableInterferences(event.getPlayer());
76+
SignChangeEvent sev = new SignChangeEvent(event.getClickedBlock(), event.getPlayer(), lines);
77+
Bukkit.getPluginManager().callEvent(sev);
78+
79+
if (!sev.isCancelled()) {
80+
lines = sev.getLines();
81+
for (int i = 0; i < lines.length; i++)
82+
s.setLine(i, lines[i]);
83+
s.update();
84+
}
85+
} finally {
86+
CompatabilityUtil.enableInterferences(event.getPlayer());
8287
}
83-
CompatabilityUtil.enableInterferences(event.getPlayer());
8488

8589
player.print("mech.signcopy.paste");
8690
event.setCancelled(true);

0 commit comments

Comments
 (0)