Skip to content

Commit f2a0b15

Browse files
committed
Drop the mixin usage
1 parent 69d094e commit f2a0b15

File tree

9 files changed

+20
-241
lines changed

9 files changed

+20
-241
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ format = { version = "1.1" }
55
indra = "3.1.3"
66
minecraft = "1.21.10"
77
fabricLoader = "0.17.3"
8-
fabricApi = "0.135.0+1.21.10"
8+
fabricApi = "0.138.0+1.21.10"
99
modmenu = "16.0.0-rc.1"
1010
viafabricplus = "3.3.0"
1111
vineflower = "1.10.1"

worldeditcui-fabric/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ loom {
3232
}
3333
}
3434

35-
mixin {
36-
defaultRefmapName.set("worldeditcui-refmap.json")
37-
}
38-
3935
accessWidenerPath.set(project.file("src/main/resources/worldeditcui.accesswidener"))
4036
}
4137

worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/callback/BlockOutlineRenderCallback.java

Lines changed: 0 additions & 44 deletions
This file was deleted.

worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/callback/WorldRenderCallback.java

Lines changed: 0 additions & 36 deletions
This file was deleted.

worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/fabric/FabricModWorldEditCUI.java

Lines changed: 19 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents;
1616
import net.fabricmc.fabric.api.client.keybinding.v1.KeyBindingHelper;
1717
import net.fabricmc.fabric.api.client.networking.v1.ClientPlayConnectionEvents;
18+
import net.fabricmc.fabric.api.client.rendering.v1.world.WorldRenderContext;
19+
import net.fabricmc.fabric.api.client.rendering.v1.world.WorldRenderEvents;
1820
import net.fabricmc.fabric.api.networking.v1.PacketSender;
1921
import net.minecraft.client.KeyMapping;
2022
import net.minecraft.client.Minecraft;
@@ -23,7 +25,6 @@
2325
import net.minecraft.resources.ResourceLocation;
2426
import net.minecraft.world.level.Level;
2527
import org.enginehub.worldeditcui.WorldEditCUI;
26-
import org.enginehub.worldeditcui.callback.WorldRenderCallback;
2728
import org.enginehub.worldeditcui.config.CUIConfiguration;
2829
import org.enginehub.worldeditcui.event.listeners.CUIListenerChannel;
2930
import org.enginehub.worldeditcui.event.listeners.CUIListenerWorldRender;
@@ -32,7 +33,6 @@
3233
import org.enginehub.worldeditcui.render.OptifinePipelineProvider;
3334
import org.enginehub.worldeditcui.render.PipelineProvider;
3435
import org.enginehub.worldeditcui.render.VanillaPipelineProvider;
35-
import org.enginehub.worldeditcui.render.WecuiRenderContext;
3636
import org.lwjgl.glfw.GLFW;
3737
import org.spongepowered.asm.mixin.MixinEnvironment;
3838

@@ -71,6 +71,8 @@ public final class FabricModWorldEditCUI implements ModInitializer {
7171
private boolean visible = true;
7272
private int delayedHelo = 0;
7373

74+
private float lastPartialTicks = 0.0f;
75+
7476
/**
7577
* Register a key binding
7678
*
@@ -96,31 +98,20 @@ public void onInitialize() {
9698
ClientLifecycleEvents.CLIENT_STARTED.register(this::onGameInitDone);
9799
CUINetworking.subscribeToCuiPacket(this::onPluginMessage);
98100
ClientPlayConnectionEvents.JOIN.register(this::onJoinGame);
99-
WorldRenderCallback.AFTER_TRANSLUCENT.register(ctx -> {
100-
if (ctx.advancedTranslucency()) {
101-
try {
102-
RenderSystem.getModelViewStack().pushMatrix();
103-
RenderSystem.getModelViewStack().mul(ctx.poseStack().last().pose());
104-
// RenderSystem.applyModelViewMatrix();
105-
//ctx.worldRenderer().getTranslucentTarget().bindWrite(false);
106-
this.onPostRenderEntities(ctx);
107-
} finally {
108-
//Minecraft.getInstance().getMainRenderTarget().bindWrite(false);
109-
RenderSystem.getModelViewStack().popMatrix();
110-
}
111-
}
101+
WorldRenderEvents.END_EXTRACTION.register(ctx -> {
102+
// MC now handles this separately to the actual render, due to it occurring across threads.
103+
// We need to store this for later use during actual render.
104+
lastPartialTicks = ctx.tickCounter().getRealtimeDeltaTicks();
112105
});
113-
WorldRenderCallback.LAST.register(ctx -> {
114-
if (!ctx.advancedTranslucency()) {
115-
try {
116-
RenderSystem.getModelViewStack().pushMatrix();
117-
RenderSystem.getModelViewStack().mul(ctx.poseStack().last().pose());
118-
// RenderSystem.applyModelViewMatrix();
119-
this.onPostRenderEntities(ctx);
120-
} finally {
121-
RenderSystem.getModelViewStack().popMatrix();
122-
// RenderSystem.applyModelViewMatrix();
123-
}
106+
WorldRenderEvents.END_MAIN.register(ctx -> {
107+
try {
108+
RenderSystem.getModelViewStack().pushMatrix();
109+
RenderSystem.getModelViewStack().mul(ctx.matrices().last().pose());
110+
// RenderSystem.applyModelViewMatrix();
111+
this.onPostRenderEntities(ctx);
112+
} finally {
113+
RenderSystem.getModelViewStack().popMatrix();
114+
// RenderSystem.applyModelViewMatrix();
124115
}
125116
});
126117
}
@@ -194,9 +185,9 @@ public void onJoinGame(final ClientPacketListener handler, final PacketSender se
194185
this.helo(handler);
195186
}
196187

197-
public void onPostRenderEntities(final WecuiRenderContext ctx) {
188+
public void onPostRenderEntities(final WorldRenderContext ctx) {
198189
if (this.visible) {
199-
this.worldRenderListener.onRender(ctx.delta().getRealtimeDeltaTicks());
190+
this.worldRenderListener.onRender(lastPartialTicks);
200191
}
201192
}
202193

worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/mixin/LevelRendererMixin.java

Lines changed: 0 additions & 70 deletions
This file was deleted.

worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/render/WecuiRenderContext.java

Lines changed: 0 additions & 41 deletions
This file was deleted.

worldeditcui-fabric/src/main/resources/fabric.mod.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
"org.enginehub.worldeditcui.fabric.ConfigPanelFactory"
3434
]
3535
},
36-
"mixins": [
37-
"worldeditcui.mixins.json"
38-
],
3936
"depends": {
4037
"worldeditcui_protocol": "*",
4138
"fabric-api-base": "*",

worldeditcui-fabric/src/main/resources/worldeditcui.mixins.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)