Workflows

Author: PDowney

.github/workflows/php-code-quality.yml

@@ -104,10 +104,10 @@ jobs:
 
           # Run the actual compatibility check
           if ! vendor/bin/phpcs --standard=phpcs.xml --extensions=php --ignore=vendor/,node_modules/ .; then
-echo "Error: The phpcs.xml standard may have issues with PHPCompatibility reference."
-echo "Trying with direct PHPCompatibility standard..."
-cp phpcs.xml phpcs.xml.bak
-cat > phpcs-compat.xml << 'EOF'
+            echo "Error: The phpcs.xml standard may have issues with PHPCompatibility reference."
+            echo "Trying with direct PHPCompatibility standard..."
+            cp phpcs.xml phpcs.xml.bak
+            cat > phpcs-compat.xml << 'EOF'
 <?xml version="1.0"?>
 <ruleset name="PHP Compatibility Check">
     <description>Check PHP compatibility for WordPress plugin</description>
@@ -120,9 +120,9 @@ cat > phpcs-compat.xml << 'EOF'
     <exclude-pattern>/node_modules/*</exclude-pattern>
 </ruleset>
 EOF
-vendor/bin/phpcs --config-set installed_paths ${ABSOLUTE_PHPCOMP_PATH},${ABSOLUTE_WPCS_PATH}
-vendor/bin/phpcs --standard=phpcs-compat.xml --extensions=php --ignore=vendor/,node_modules/ .
-fi
+            vendor/bin/phpcs --config-set installed_paths ${ABSOLUTE_PHPCOMP_PATH},${ABSOLUTE_WPCS_PATH}
+            vendor/bin/phpcs --standard=phpcs-compat.xml --extensions=php --ignore=vendor/,node_modules/ .
+          fi
 
       - name: Fix text argument escaping issues
         run: |

.github/workflows/wordpress-tests.yml

@@ -279,8 +279,8 @@ jobs:
           else
             echo "::warning::Files may be missing in /wordpress-tests-lib, creating core files if needed"
             sudo mkdir -p /wordpress-tests-lib/includes/
-            sudo cp -f /tmp/wordpress-tests-lib/includes/functions.php /wordpress-tests-lib/includes/ || echo "::warning::Failed to copy functions.php"
-            sudo cp -f /tmp/wordpress-tests-lib/wp-tests-config.php /wordpress-tests-lib/ || echo "::warning::Failed to copy wp-tests-config.php"
+            if ! sudo cp -f /tmp/wordpress-tests-lib/includes/functions.php /wordpress-tests-lib/includes/; then echo "::warning::Failed to copy functions.php"; fi
+            if ! sudo cp -f /tmp/wordpress-tests-lib/wp-tests-config.php /wordpress-tests-lib/; then echo "::warning::Failed to copy wp-tests-config.php"; fi
           fi
           
           # Create or copy required class-basic-object.php file if missing