Skip to content

Commit 93e9f91

Browse files
committed
fix code review comments
1 parent 209fe38 commit 93e9f91

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public String field(@GraphQLDefaultValue(DefaultValue.class) String value) {
250250
The `DefaultValue` class can define a `getInstance` method that will be called instead of the default constructor.
251251

252252
`@GraphQLDeprecate` and Java's `@Deprecated` can be used to specify a deprecated
253-
field.
253+
field, method or a type.
254254

255255
### Custom data fetcher
256256

build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ plugins {
1818
apply plugin: 'java'
1919
apply plugin: 'idea'
2020

21-
//apply plugin: 'osgi'
2221
apply plugin: 'biz.aQute.bnd.builder'
2322
apply plugin: 'com.jfrog.bintray'
2423
apply plugin: 'maven-publish'

src/test/java/graphql/annotations/processor/retrievers/fieldBuilders/DeprecateBuilderTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,14 @@
2525

2626
public class DeprecateBuilderTest {
2727

28+
@GraphQLDeprecate("test field deprecated")
29+
public String testField;
30+
31+
@GraphQLDeprecate
32+
public String testField1;
33+
34+
public String testField2;
35+
2836
@GraphQLDeprecate("test deprecated")
2937
public int testMethod() {
3038
return 1;
@@ -44,14 +52,6 @@ public int testMethod4() {
4452
return 1;
4553
}
4654

47-
@GraphQLDeprecate("test field deprecated")
48-
public String testField;
49-
50-
@GraphQLDeprecate
51-
public String testField1;
52-
53-
public String testField2;
54-
5555
@Test
5656
public void build_graphQLDeprecateAnnotationExistsWithValue_returnAnnotationValue() throws NoSuchMethodException {
5757
// arrange

0 commit comments

Comments
 (0)