Skip to content

Commit 35c6c5d

Browse files
committed
Mute some checks improved in clang-tidy20 in yql
Original errors you can see [here](https://nda.ya.ru/t/OlFnpgnP7L8aiS commit_hash:54941c5afadf626d30f5a9ab60de7b29ab625926
1 parent 1f3c5d9 commit 35c6c5d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

yql/essentials/udfs/common/stat/static/stat_udf.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ extern const char DigestResourceName[] = "Stat.TDigestResource";
1414
typedef TBoxedResource<TDigest, DigestResourceName> TDigestResource;
1515
typedef TRefCountedPtr<TDigestResource> TDigestResourcePtr;
1616

17-
SIMPLE_UDF_WITH_OPTIONAL_ARGS(TTDigest_Create, TResource<DigestResourceName>(double, TOptional<double>, TOptional<double>), 2) {
17+
SIMPLE_UDF_WITH_OPTIONAL_ARGS(TTDigest_Create, TResource<DigestResourceName>(double, TOptional<double>, TOptional<double>), 2) { // NOLINT(readability-identifier-naming)
1818
Y_UNUSED(valueBuilder);
1919
const double delta = args[1].GetOrDefault<double>(0.01);
2020
const double K = args[2].GetOrDefault<double>(25.0);
@@ -25,31 +25,31 @@ SIMPLE_UDF_WITH_OPTIONAL_ARGS(TTDigest_Create, TResource<DigestResourceName>(dou
2525
return TUnboxedValuePod(new TDigestResource(delta, K, args[0].Get<double>(), true));
2626
}
2727

28-
SIMPLE_STRICT_UDF(TTDigest_AddValue, TResource<DigestResourceName>(TResource<DigestResourceName>, double)) {
28+
SIMPLE_STRICT_UDF(TTDigest_AddValue, TResource<DigestResourceName>(TResource<DigestResourceName>, double)) { // NOLINT(readability-identifier-naming)
2929
Y_UNUSED(valueBuilder);
3030
TDigestResource::Validate(args[0]);
3131
TDigestResource* resource = static_cast<TDigestResource*>(args[0].AsBoxed().Get());
3232
resource->Get()->AddValue(args[1].Get<double>());
3333
return TUnboxedValuePod(resource);
3434
}
3535

36-
SIMPLE_STRICT_UDF(TTDigest_GetPercentile, double(TResource<DigestResourceName>, double)) {
36+
SIMPLE_STRICT_UDF(TTDigest_GetPercentile, double(TResource<DigestResourceName>, double)) { // NOLINT(readability-identifier-naming)
3737
Y_UNUSED(valueBuilder);
3838
TDigestResource::Validate(args[0]);
3939
return TUnboxedValuePod(static_cast<TDigestResource*>(args[0].AsBoxed().Get())->Get()->GetPercentile(args[1].Get<double>()));
4040
}
4141

42-
SIMPLE_STRICT_UDF(TTDigest_Serialize, char*(TResource<DigestResourceName>)) {
42+
SIMPLE_STRICT_UDF(TTDigest_Serialize, char*(TResource<DigestResourceName>)) { // NOLINT(readability-identifier-naming)
4343
TDigestResource::Validate(args[0]);
4444
return valueBuilder->NewString(static_cast<TDigestResource*>(args[0].AsBoxed().Get())->Get()->Serialize());
4545
}
4646

47-
SIMPLE_UDF(TTDigest_Deserialize, TResource<DigestResourceName>(char*)) {
47+
SIMPLE_UDF(TTDigest_Deserialize, TResource<DigestResourceName>(char*)) { // NOLINT(readability-identifier-naming)
4848
Y_UNUSED(valueBuilder);
4949
return TUnboxedValuePod(new TDigestResource(TString(args[0].AsStringRef()), true));
5050
}
5151

52-
SIMPLE_STRICT_UDF(TTDigest_Merge, TResource<DigestResourceName>(TResource<DigestResourceName>, TResource<DigestResourceName>)) {
52+
SIMPLE_STRICT_UDF(TTDigest_Merge, TResource<DigestResourceName>(TResource<DigestResourceName>, TResource<DigestResourceName>)) { // NOLINT(readability-identifier-naming)
5353
Y_UNUSED(valueBuilder);
5454
TDigestResource::Validate(args[0]);
5555
TDigestResource::Validate(args[1]);

yql/essentials/udfs/common/string/string_udf.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ BEGIN_SIMPLE_STRICT_ARROW_UDF_OPTIONS(TAsciiContainsIgnoreCase, bool(TOptional<c
568568

569569
END_SIMPLE_ARROW_UDF(TAsciiContainsIgnoreCase, TAsciiContainsIgnoreCaseKernelExec::Do);
570570

571-
BEGIN_SIMPLE_STRICT_ARROW_UDF(T_yql_AsciiContainsIgnoreCase, bool(TOptional<char*>, char*))
571+
BEGIN_SIMPLE_STRICT_ARROW_UDF(T_yql_AsciiContainsIgnoreCase, bool(TOptional<char*>, char*)) // NOLINT(readability-identifier-naming)
572572
{
573573
Y_UNUSED(valueBuilder);
574574
return AsciiContainsIgnoreCaseImpl(args);

0 commit comments

Comments
 (0)