YQL-20068 backport mode

commit_hash:4ad0e146a3e92836d6aec7eaac00ae0225484b09

Author: vitstn

yql/essentials/core/langver/yql_core_langver.cpp

@@ -29,7 +29,7 @@ bool CheckLangVersion(TLangVersion ver, TLangVersion max, TMaybe<TIssue>& issue)
         return false;
     }
 
-    if (!IsAvalableLangVersion(ver, max)) {
+    if (!IsAvailableLangVersion(ver, max)) {
         TStringBuilder builder;
         builder << "YQL language version '";
         WriteVersion(builder, ver);

yql/essentials/core/type_ann/type_ann_core.cpp

@@ -7626,7 +7626,10 @@ template <NKikimr::NUdf::EDataSlot DataSlot>
                     }
 
                     if (ctx.Types.LangVer != UnknownLangVersion) {
-                        if (settingName == "minLang" && ctx.Types.LangVer < FromString<NYql::TLangVersion>(child->Tail().Content())) {
+                        if (settingName == "minLang" && !IsBackwardCompatibleFeatureAvailable(
+                                ctx.Types.LangVer,
+                                FromString<NYql::TLangVersion>(child->Tail().Content()),
+                                ctx.Types.BackportMode)) {
                             TLangVersionBuffer buffer;
                             TStringBuf str;
                             if (!FormatLangVersion(FromString<NYql::TLangVersion>(child->Tail().Content()), buffer, str)) {

yql/essentials/core/yql_type_annotation.h

@@ -386,6 +386,7 @@ struct TTypeAnnotationContext: public TThrRefBase {
     TSimpleSharedPtr<NDq::TOrderingsStateMachine> SortingsFSM;
     TSimpleSharedPtr<NDq::TOrderingsStateMachine> OrderingsFSM;
     TLangVersion LangVer = MinLangVersion;
+    EBackportCompatibleFeaturesMode BackportMode = EBackportCompatibleFeaturesMode::None;
     THashMap<TString, TIntrusivePtr<TOptimizerStatistics::TColumnStatMap>> ColumnStatisticsByTableName;
     THashMap<ui64, std::shared_ptr<TOptimizerStatistics>> StatisticsMap;
     TIntrusivePtr<ITimeProvider> TimeProvider;

yql/essentials/public/langver/ut/yql_langver_ut.cpp

@@ -48,8 +48,8 @@ Y_UNIT_TEST_SUITE(TLangVerTests) {
     }
 
     Y_UNIT_TEST(Available) {
-        UNIT_ASSERT(IsAvalableLangVersion(MakeLangVersion(2025,2),MakeLangVersion(2025,2)));
-        UNIT_ASSERT(!IsAvalableLangVersion(MakeLangVersion(2025,3),MakeLangVersion(2025,2)));
+        UNIT_ASSERT(IsAvailableLangVersion(MakeLangVersion(2025,2),MakeLangVersion(2025,2)));
+        UNIT_ASSERT(!IsAvailableLangVersion(MakeLangVersion(2025,3),MakeLangVersion(2025,2)));
     }
 
     Y_UNIT_TEST(MaxReleasedLangVersionIsValid) {
@@ -63,6 +63,33 @@ Y_UNIT_TEST_SUITE(TLangVerTests) {
     Y_UNIT_TEST(MaxVersionIsAboveThanReleased) {
         UNIT_ASSERT(GetMaxLangVersion() > GetMaxReleasedLangVersion());
     }
+
+    Y_UNIT_TEST(BackwardCompatibleFeatureAvailable_All) {
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, MinLangVersion,
+            EBackportCompatibleFeaturesMode::All));
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxReleasedLangVersion(),
+            EBackportCompatibleFeaturesMode::All));
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxLangVersion(),
+            EBackportCompatibleFeaturesMode::All));
+    }
+
+    Y_UNIT_TEST(BackwardCompatibleFeatureAvailable_Released) {
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, MinLangVersion,
+            EBackportCompatibleFeaturesMode::Released));
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxReleasedLangVersion(),
+            EBackportCompatibleFeaturesMode::Released));
+        UNIT_ASSERT(!IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxLangVersion(),
+            EBackportCompatibleFeaturesMode::Released));
+    }
+
+    Y_UNIT_TEST(BackwardCompatibleFeatureAvailable_None) {
+        UNIT_ASSERT(IsBackwardCompatibleFeatureAvailable(MinLangVersion, MinLangVersion,
+            EBackportCompatibleFeaturesMode::None));
+        UNIT_ASSERT(!IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxReleasedLangVersion(),
+            EBackportCompatibleFeaturesMode::None));
+        UNIT_ASSERT(!IsBackwardCompatibleFeatureAvailable(MinLangVersion, GetMaxLangVersion(),
+            EBackportCompatibleFeaturesMode::None));
+    }
 }
 
 }

yql/essentials/public/langver/ya.make

@@ -7,6 +7,8 @@ SRCS(
 PEERDIR(
 )
 
+GENERATE_ENUM_SERIALIZATION(yql_langver.h)
+
 END()
 
 RECURSE_FOR_TESTS(

yql/essentials/public/langver/yql_langver.cpp

@@ -83,4 +83,16 @@ TLangVersion GetMaxLangVersion() {
     return max;
 }
 
+bool IsBackwardCompatibleFeatureAvailable(TLangVersion currentVer, TLangVersion featureVer,
+    EBackportCompatibleFeaturesMode mode) {
+    switch (mode) {
+    case EBackportCompatibleFeaturesMode::All:
+        return true;
+    case EBackportCompatibleFeaturesMode::Released:
+        return IsAvailableLangVersion(featureVer, GetMaxReleasedLangVersion());
+    case EBackportCompatibleFeaturesMode::None:
+        return IsAvailableLangVersion(featureVer, currentVer);
+    }
+}
+
 }

yql/essentials/public/langver/yql_langver.h

@@ -22,7 +22,7 @@ constexpr inline ui32 GetMinorFromLangVersion(TLangVersion ver) {
     return ver % 100u;
 }
 
-constexpr inline bool IsAvalableLangVersion(TLangVersion ver, TLangVersion max) {
+constexpr inline bool IsAvailableLangVersion(TLangVersion ver, TLangVersion max) {
     if (ver == UnknownLangVersion || max == UnknownLangVersion) {
         return true;
     }
@@ -58,4 +58,13 @@ bool IsValidLangVersion(TLangVersion ver);
 bool ParseLangVersion(TStringBuf str, TLangVersion& result);
 bool FormatLangVersion(TLangVersion ver, TLangVersionBuffer& buffer, TStringBuf& result);
 
+enum class EBackportCompatibleFeaturesMode {
+    None,
+    Released,
+    All
+};
+
+bool IsBackwardCompatibleFeatureAvailable(TLangVersion currentVer, TLangVersion featureVer,
+    EBackportCompatibleFeaturesMode mode);
+
 }

yql/essentials/sql/settings/translation_settings.h

@@ -78,6 +78,7 @@ namespace NSQLTranslation {
         google::protobuf::Arena* Arena = nullptr;
 
         NYql::TLangVersion LangVer = NYql::MinLangVersion;
+        NYql::EBackportCompatibleFeaturesMode BackportMode = NYql::EBackportCompatibleFeaturesMode::None;
         THashMap<TString, TString> ClusterMapping;
         TString PathPrefix;
         // keys (cluster name) should be normalized