YT-16908: During replication card serialization sort replicas map iterators instead of copying replica infos

olegsidorkin · olegsidorkin · commit ed00d7754d7a · 2025-09-11T12:07:11.000+03:00
commit_hash:c20233743374bd032121441a7464664e9caff96e
diff --git a/yt/yt/client/chaos_client/replication_card_serialization.cpp b/yt/yt/client/chaos_client/replication_card_serialization.cpp
@@ -402,10 +402,11 @@ void ToProto(
     const TReplicationCardFetchOptions& options)
 {
     protoReplicationCard->mutable_replicas()->Reserve(replicationCard.Replicas.size());
-    for (const auto& [replicaId, replicaInfo] : SortHashMapByKeys(replicationCard.Replicas)) {
+    auto sortedIterators = GetSortedIterators(replicationCard.Replicas);
+    for (const auto& iterator : sortedIterators) {
         auto* protoReplicaEntry = protoReplicationCard->add_replicas();
-        ToProto(protoReplicaEntry->mutable_id(), replicaId);
-        ToProto(protoReplicaEntry->mutable_info(), replicaInfo, options);
+        ToProto(protoReplicaEntry->mutable_id(), iterator->first);
+        ToProto(protoReplicaEntry->mutable_info(), iterator->second, options);
     }
 
     if (options.IncludeCoordinators) {

Original file line number	Diff line number	Diff line change
`@@ -402,10 +402,11 @@ void ToProto(`
`402`	`402`	`const TReplicationCardFetchOptions& options)`
`403`	`403`	`{`
`404`	`404`	`protoReplicationCard->mutable_replicas()->Reserve(replicationCard.Replicas.size());`
`405`		`- for (const auto& [replicaId, replicaInfo] : SortHashMapByKeys(replicationCard.Replicas)) {`
	`405`	`+ auto sortedIterators = GetSortedIterators(replicationCard.Replicas);`
	`406`	`+ for (const auto& iterator : sortedIterators) {`
`406`	`407`	`auto* protoReplicaEntry = protoReplicationCard->add_replicas();`
`407`		`- ToProto(protoReplicaEntry->mutable_id(), replicaId);`
`408`		`- ToProto(protoReplicaEntry->mutable_info(), replicaInfo, options);`
	`408`	`+ ToProto(protoReplicaEntry->mutable_id(), iterator->first);`
	`409`	`+ ToProto(protoReplicaEntry->mutable_info(), iterator->second, options);`
`409`	`410`	`}`
`410`	`411`
`411`	`412`	`if (options.IncludeCoordinators) {`