Skip to content

Commit 84ec724

Browse files
committed
2 parents e54333e + 7b3829a commit 84ec724

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## [2.1.1] - (2024-05-22)
2+
- Remove direct MailClient usage from MimeMessageDownloader
3+
- Update dependencies
4+
15
## [2.1.0] - 2023-10-05
26
- Switch to inapp_webview 6 (beta)
37
- Feat: support to specify own fetching method, Setting your own fetching method can be useful for downloading the message contents e.g. from disk.

lib/src/mime_message_viewer.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ class _HtmlGenerationArguments {
120120
required this.enableDarkMode,
121121
required this.preferPlainText,
122122
required this.blockExternalImages,
123-
required this.logger,
124123
});
125124

126125
final MimeMessage mimeMessage;
@@ -129,7 +128,6 @@ class _HtmlGenerationArguments {
129128
final bool enableDarkMode;
130129
final String? emptyMessageText;
131130
final int? maxImageWidth;
132-
final Logger logger;
133131
}
134132

135133
class _HtmlGenerationResult {
@@ -185,13 +183,13 @@ class _HtmlViewerState extends State<_HtmlMimeMessageViewer> {
185183
preferPlainText: preferPlainText,
186184
enableDarkMode: enableDarkMode,
187185
blockExternalImages: blockExternalImages,
188-
logger: widget.config.logger ?? defaultLogger,
189186
);
190187
final result = await compute(_generateHtmlImpl, args);
191188
_htmlData = result.html;
192189
if (_htmlData == null) {
193190
widget.config.onError?.call(result.errorDetails, null);
194191
}
192+
widget.config.logger?.d('generated html: $_htmlData');
195193
if (mounted) {
196194
setState(() {
197195
_isGenerating = false;
@@ -210,14 +208,11 @@ class _HtmlViewerState extends State<_HtmlMimeMessageViewer> {
210208
emptyMessageText: args.emptyMessageText,
211209
maxImageWidth: args.maxImageWidth,
212210
);
213-
args.logger.d(html);
214211

215212
return _HtmlGenerationResult.success(html);
216213
} catch (e, s) {
217-
args.logger.e(
214+
debugPrint(
218215
'unable to transform mime message to HTML: $e',
219-
error: e,
220-
stackTrace: s,
221216
);
222217
final errorDetails = '$e\n\n$s';
223218

pubspec.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: enough_mail_flutter
22
description: Widgets for email apps that use the `enough_mail` library. Licensed commercially friendly under MPL 2.0.
3-
version: 2.1.0
3+
version: 2.1.1
44
homepage: https://github.com/enough-software/enough_mail_flutter
55
topics:
66
- mime
@@ -13,15 +13,14 @@ environment:
1313
dependencies:
1414
enough_mail: ^2.1.2
1515
enough_mail_html: ^2.0.1
16-
enough_media: ^2.2.1
16+
enough_media: ^2.3.1
1717
flutter:
1818
sdk: flutter
19-
flutter_inappwebview: '^6.0.0'
19+
flutter_inappwebview: ^6.0.0
2020
logger: ^2.0.0
2121
url_launcher: ^6.0.0
2222

2323
dependency_overrides:
24-
http: ^1.1.0 #for dart_code_metrics
2524
# xml: ^6.0.1
2625
# out-comment the following to enable local development:
2726
# enough_mail:
@@ -40,7 +39,6 @@ dependency_overrides:
4039

4140

4241
dev_dependencies:
43-
dart_code_metrics: 5.7.6
4442
flutter_lints: ^4.0.0
4543
flutter_test:
4644
sdk: flutter

0 commit comments

Comments
 (0)