Ignore non-finite values, they are not supported in line protocol

Author: Enric Sala

influxdb-client/Point.m

@@ -25,10 +25,10 @@
 
         % Add a field value
         function obj = field(obj, key, value)
-            if isempty(value)
-                error('field:emptyValue', 'value of field "%s" is empty', key);
-            elseif isfloat(value)
-                obj.Fields{end + 1} = sprintf('%s=%.8g', key, value);
+            if isfloat(value)
+                if ~isempty(value) && isfinite(value)
+                    obj.Fields{end + 1} = sprintf('%s=%.8g', key, value);
+                end
             elseif isinteger(value)
                 obj.Fields{end + 1} = sprintf('%s=%ii', key, value);
             elseif ischar(value)
@@ -58,15 +58,18 @@
 
         % Format to Line Protocol
         function line = toLine(obj, precision)
-            assert(~isempty(obj.Name), 'toLine:emptyName', 'series name cannot be empty');
-            assert(~isempty(obj.Fields), 'toLine:emptyFields', 'must define at least one field');
-            start = strjoin([{obj.Name}, obj.Tags], ',');
-            fields = strjoin(obj.Fields, ',');
-            if isempty(obj.Time)
-                line = [start, ' ', fields];
+            if isempty(obj.Fields)
+                line = '';
             else
-                if nargin < 2, precision = 'ms'; end
-                line = [start, ' ', fields, ' ', obj.timeFmt(precision)];
+                assert(~isempty(obj.Name), 'toLine:emptyName', 'series name cannot be empty');
+                start = strjoin([{obj.Name}, obj.Tags], ',');
+                fields = strjoin(obj.Fields, ',');
+                if isempty(obj.Time)
+                    line = [start, ' ', fields];
+                else
+                    if nargin < 2, precision = 'ms'; end
+                    line = [start, ' ', fields, ' ', obj.timeFmt(precision)];
+                end
             end
         end
     end

influxdb-client/Series.m

@@ -85,11 +85,14 @@
                 end
                 point.time(obj.Time(i));
                 if nargin < 2
-                    builder.append(point.toLine());
+                    line = point.toLine();
                 else
-                    builder.append(point.toLine(precision))
+                    line = point.toLine(precision);
+                end
+                if ~isempty(line)
+                    builder.append(line);
+                    builder.append(newline);
                 end
-                builder.append(newline);
             end
             builder.deleteCharAt(int32(builder.length() - 1));
             lines = char(builder.toString());

tests/PointTest.m

@@ -2,22 +2,30 @@
 
     methods(Test)
         function build_fails_when_empty_name(test)
-            f = @() Point('').toLine();
+            f = @() Point('').fields('temperature', 24.3).toLine();
             test.verifyError(f, 'toLine:emptyName');
         end
 
-        function build_fails_when_empty_fields(test)
-            f = @() Point('weather').toLine();
-            test.verifyError(f, 'toLine:emptyFields');
+        function single_field(test)
+            p = Point('weather').fields('temperature', 24.3);
+            exp = 'weather temperature=24.3';
+            test.verifyEqual(p.toLine(), exp);
         end
 
-        function field_with_empty_value_fails(test)
-            f = @() Point('weather').fields('temperature', []);
-            test.verifyError(f, 'field:emptyValue');
+        function when_empty_fields_return_empty(test)
+            p = Point('weather');
+            test.verifyEqual(p.toLine(), '');
         end
 
-        function single_field(test)
-            p = Point('weather').fields('temperature', 24.3);
+        function empty_fields_are_ignored(test)
+            p = Point('weather').fields('temperature', [], 'humidity', 60.7);
+            exp = 'weather humidity=60.7';
+            test.verifyEqual(p.toLine(), exp);
+        end
+        
+        function nonfinite_fields_are_ignored(test)
+            p = Point('weather').fields('temperature', 24.3) ...
+                .fields('rain', Inf, 'humidity', NaN, 'sun', -Inf);
             exp = 'weather temperature=24.3';
             test.verifyEqual(p.toLine(), exp);
         end

tests/SeriesTest.m

@@ -180,6 +180,15 @@ function every_property_is_used(test)
                 'weather,city=barcelona temperature=-3.5 1529933581618'];
             test.verifyEqual(s.toLine(), exp);
         end
+        
+        function skips_nonfinite_samples(test)
+            s = Series('weather') ...
+                .time(test.Time) ...
+                .fields('temperature', [24.3, Inf]) ...
+                .fields('humidity', [-Inf, NaN]);
+            exp = 'weather temperature=24.3 1529933525520';
+            test.verifyEqual(s.toLine(), exp);
+        end
     end
 
 end