fix(recovery): fix external cluster validation (cloudnative-pg#10268)

Add missing check for `ConnectionParameters` in
`validateBootstrapRecoverySource` and update the error message to
include all valid configuration types.

Closes cloudnative-pg#10260

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

Author: gbartolini

internal/webhook/v1/cluster_webhook.go

@@ -682,14 +682,16 @@ func (v *ClusterCustomValidator) validateBootstrapRecoverySource(r *apiv1.Cluste
 
 	// Ensure the external cluster definition has enough information
 	// to be used to recover a data directory
-	if externalCluster.BarmanObjectStore == nil && externalCluster.PluginConfiguration == nil {
+	if externalCluster.ConnectionParameters == nil &&
+		externalCluster.BarmanObjectStore == nil &&
+		externalCluster.PluginConfiguration == nil {
 		result = append(
 			result,
 			field.Invalid(
 				field.NewPath("spec", "bootstrap", "recovery", "source"),
 				r.Spec.Bootstrap.Recovery.Source,
 				fmt.Sprintf("External cluster %v cannot be used for recovery: "+
-					"both Barman and CNPG-i plugin configurations are missing", r.Spec.Bootstrap.Recovery.Source)))
+					"missing connection parameters, Barman, or CNPG-i configuration", r.Spec.Bootstrap.Recovery.Source)))
 	}
 
 	return result

pkg/management/postgres/restore.go

@@ -154,9 +154,12 @@ func (info InitInfo) RestoreSnapshot(ctx context.Context, cli client.Client, imm
 		restoreCmd)
 
 	if pluginConfiguration := cluster.GetRecoverySourcePlugin(); pluginConfiguration == nil {
-		envs, config, err = info.createEnvAndConfigForSnapshotRestore(ctx, cli, cluster)
-		if err != nil {
-			return err
+		server, found := cluster.ExternalCluster(cluster.Spec.Bootstrap.Recovery.Source)
+		if found && server.BarmanObjectStore != nil {
+			envs, config, err = info.createEnvAndConfigForSnapshotRestore(ctx, cli, cluster, &server)
+			if err != nil {
+				return err
+			}
 		}
 	}
 
@@ -218,20 +221,12 @@ func (info InitInfo) createEnvAndConfigForSnapshotRestore(
 	ctx context.Context,
 	typedClient client.Client,
 	cluster *apiv1.Cluster,
+	server *apiv1.ExternalCluster,
 ) ([]string, string, error) {
 	contextLogger := log.FromContext(ctx)
-	sourceName := cluster.Spec.Bootstrap.Recovery.Source
-
-	if sourceName == "" {
-		return nil, "", fmt.Errorf("recovery source not specified")
-	}
 
-	contextLogger.Info("Recovering from external cluster", "sourceName", sourceName)
+	contextLogger.Info("Recovering from external cluster", "sourceName", server.Name)
 
-	server, found := cluster.ExternalCluster(sourceName)
-	if !found {
-		return nil, "", fmt.Errorf("missing external cluster: %v", sourceName)
-	}
 	serverName := server.GetServerName()
 
 	env, err := barmanCredentials.EnvSetRestoreCloudCredentials(