Add mypy auto check and fix easy errors

Summary:

Add mypy automated check and fix any of the easy errors that don't result in functional changes

Test Plan:

Run `mypy functional`

Author: EntilZha

.github/workflows/pythonpackage.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "pypy3.9"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "pypy3.9"]
         include:
           - python-version: "3.11"
             use_pandas: 1
@@ -35,6 +35,9 @@ jobs:
       - name: Test with pytest
         run: poetry run pytest --cov=functional --cov-report=xml
         if: always()
+      - name: mypy
+        run: poetry run mypy functional
+        if: always()
       - uses: codecov/codecov-action@v1
         with:
           file: ./coverage.xml

README.md

@@ -489,7 +489,7 @@ In order to be merged, all pull requests must:
 [Gitter for chat](https://gitter.im/EntilZha/PyFunctional)
 
 ## Supported Python Versions
-* `PyFunctional` 1.5 is tested against Python 3.7 to 3.11 and PyPy3
+* `PyFunctional` 1.5 is tested against Python 3.8 to 3.11 and PyPy3
 * `PyFunctional` 1.4 supports and is tested against Python 3.6, Python 3.7, and PyPy3
 * `PyFunctional` 1.4 and above do not support python 2.7
 * `PyFunctional` 1.4 works in Python 3.5, but is not tested against it

functional/io.py

@@ -288,7 +288,7 @@ def get_read_function(filename: str, disable_compression: bool):
     with open(filename, "rb") as f:
         start_bytes = f.read(N_COMPRESSION_CHECK_BYTES)
         for cls in COMPRESSION_CLASSES:
-            if cls.is_compressed(start_bytes):
+            if cls.is_compressed(start_bytes):  # type: ignore
                 return cls
         return ReusableFile
 

functional/pipeline.py

@@ -11,7 +11,7 @@
 import re
 
 from collections.abc import Iterable
-from typing import Optional
+from typing import List, Optional, Tuple, Union
 
 from tabulate import tabulate
 
@@ -40,7 +40,7 @@ def __init__(
         self,
         sequence: Iterable,
         transform=None,
-        engine: ExecutionEngine = None,
+        engine: Optional[ExecutionEngine] = None,
         max_repr_items: Optional[int] = None,
         no_wrap: Optional[bool] = None,
     ):
@@ -59,9 +59,13 @@ def __init__(
         """
         self.engine = engine or ExecutionEngine()
         if isinstance(sequence, Sequence):
-            self._max_repr_items = max_repr_items or sequence._max_repr_items
-            self._base_sequence = sequence._base_sequence
-            self._lineage = Lineage(prior_lineage=sequence._lineage, engine=engine)
+            self._max_repr_items: Optional[int] = (
+                max_repr_items or sequence._max_repr_items
+            )
+            self._base_sequence: Union[Iterable, List, Tuple] = sequence._base_sequence
+            self._lineage: Lineage = Lineage(
+                prior_lineage=sequence._lineage, engine=engine
+            )
         elif isinstance(sequence, (list, tuple)) or is_iterable(sequence):
             self._max_repr_items = max_repr_items
             self._base_sequence = sequence

functional/util.py

@@ -3,8 +3,9 @@
 from functools import reduce
 from itertools import chain, count, islice, takewhile
 from multiprocessing import Pool, cpu_count
+from typing import Any
 
-import dill as serializer
+import dill as serializer  # type: ignore
 
 
 PROTOCOL = serializer.HIGHEST_PROTOCOL
@@ -188,7 +189,7 @@ def compose(*functions):
     return reduce(lambda f, g: lambda x: f(g(x)), functions, lambda x: x)
 
 
-def default_value(*vals: tuple):
+def default_value(*vals: Any):
     for val in vals:
         if val is not None:
             return val

poetry.lock

@@ -14,7 +14,6 @@ classifiers = [
     'Development Status :: 5 - Production/Stable',
     'Intended Audience :: Developers',
     'License :: OSI Approved :: MIT License',
-    'Programming Language :: Python :: 3.7',
     'Programming Language :: Python :: 3.8',
     'Programming Language :: Python :: 3.9',
     'Programming Language :: Python :: 3.10',
@@ -28,7 +27,7 @@ classifiers = [
 packages = [{ include = "functional" }]
 
 [tool.poetry.dependencies]
-python = "^3.7.2"
+python = "^3.8.0"
 dill = ">=0.2.5"
 tabulate = "<=1.0.0"
 pandas = { version = "^1.0.3", optional = true }
@@ -45,6 +44,8 @@ coverage = "^7.2.5"
 
 [tool.poetry.group.dev.dependencies]
 mypy = "^1.1.1"
+types-tabulate = "^0.9.0.3"
+pandas-stubs = "^2.0.3.230814"
 
 [build-system]
 requires = ["poetry>=0.12"]