Revert "First activity cache" #2595
Open
+2
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/analyses/activity.jl b/src/analyses/activity.jl
index 871e7cd..87484af 100644
--- a/src/analyses/activity.jl
+++ b/src/analyses/activity.jl
@@ -393,7 +393,7 @@ Base.@nospecializeinfer @inline function active_reg_inner(
return ty
end
-Base.@nospecializeinfer @inline function active_reg(@nospecialize(ST::Type), world::UInt; justActive=false, UnionSret = false, AbstractIsMixed = false)
+Base.@nospecializeinfer @inline function active_reg(@nospecialize(ST::Type), world::UInt; justActive = false, UnionSret = false, AbstractIsMixed = false)
set = Base.IdSet{Type}()
return active_reg_inner(ST, set, world, justActive, UnionSret, AbstractIsMixed)
end
diff --git a/src/compiler.jl b/src/compiler.jl
index b209b87..794a526 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -6242,7 +6242,7 @@ function thunk_generator(world::UInt, source::Union{Method, LineNumberNode}, @no
mi = my_methodinstance(Mode == API.DEM_ForwardMode ? Forward : Reverse, ft, primal_tt, world, min_world, max_world)
mi === nothing && return stub(world, source, method_error)
-
+
min_world2 = Ref{UInt}(typemin(UInt))
max_world2 = Ref{UInt}(typemax(UInt))
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
- Coverage 75.24% 75.21% -0.03%
==========================================
Files 57 57
Lines 17928 17897 -31
==========================================
- Hits 13490 13462 -28
+ Misses 4438 4435 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/18142076439/artifacts/4147923454. |
This reverts commit 71a5afd.
vchuravy
force-pushed
the
revert-2594-acache
branch
from
cffa09d to
162179a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2594
The current design is prone to "spurious results from the future" and I think it is better to implement this either as a local cache or with proper invalidation integration