Call Ops.fill in similar for Broadcasted argument (#1305)

* call `Ops.fill` in `similar` for `Broadcasted` argument

* fix

* Update test/ops.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: jumerckx

src/TracedRArray.jl

@@ -675,14 +675,14 @@ function Base.similar(
     ::Broadcasted{AbstractReactantArrayStyle{N}}, ::Type{T}, dims
 ) where {T<:Reactant.ReactantPrimitive,N}
     @assert N isa Int
-    return TracedRArray{T,length(dims)}((), nothing, map(length, dims))
+    return Ops.fill(zero(unwrapped_eltype(T)), dims)
 end
 
 function Base.similar(
     ::Broadcasted{AbstractReactantArrayStyle{N}}, ::Type{TracedRNumber{T}}, dims
 ) where {T<:Reactant.ReactantPrimitive,N}
     @assert N isa Int
-    return TracedRArray{T,length(dims)}((), nothing, map(length, dims))
+    return Ops.fill(zero(T), dims)
 end
 
 function Broadcast.copy(bc::Broadcasted{<:AbstractReactantArrayStyle{0}})

test/ops.jl

@@ -1135,6 +1135,9 @@ end
     mod = @code_hlo optimize = false const_dedup(x)
     hlo_ir = repr(mod)
     csts = collect(x for x in eachsplit(hlo_ir, "\n") if occursin("stablehlo.constant", x))
+    # calls to similar give rise to dense<0> constants (that are not deduplicated):
+    csts = filter(x -> !occursin("dense<0>", x), csts)
+
     @test length(csts) == 2
     idx = findfirst(x -> occursin("1, 2, 3, 4", x), csts)
     @test idx !== nothing