[deps] Some improvements to the build_local.jl script (#689)

* [deps] Some improvements to the `build_local.jl` script

Remove unused packages from the environment, add more arguments to the script.

* [deps] Remove more unused stuff

* [deps] Automatically disable component depending on GCC version

* [deps] Try to improve the GCC regex

* [deps] Some fixes to gcc version checks logic

Author: giordano

deps/Project.toml

@@ -1,11 +1,3 @@
 [deps]
 ArgParse = "c7e460c6-2fb9-53a9-8c5b-16f535851c63"
-BinaryBuilderBase = "7f725544-6523-48cd-82d1-3fa08ff4056e"
-Clang = "40e3b903-d033-50b4-a0cc-940c62c95e31"
-Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
-Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Preferences = "21216c6a-2e73-6563-6e65-726566657250"
-Scratch = "6c6a2e73-6563-6170-7368-637461726353"
-
-[compat]
-Clang = "0.18"

deps/build_local.jl

@@ -27,13 +27,22 @@ s = ArgParseSettings()
         help = "Hermetic Python version."
         default = "3.10"
         arg_type = String
-    # For GCC < 13 we need to disable these flags
-    "--xnn_disable_avx512fp16"
-        help = "Disable AVX512 FP16 support in XNNPACK."
-        action = :store_true
-    "--xnn_disable_avxvnniint8"
-        help = "Disable AVX VNNI INT8 support in XNNPACK."
-        action = :store_true
+    "--jobs"
+        help = "Number of parallel jobs."
+        default = Sys.CPU_THREADS
+        arg_type = Int
+    "--copt"
+        help = "Options to be passed to the C compiler.  Can be used multiple times."
+        action = :append_arg
+        arg_type = String
+    "--cxxopt"
+        help = "Options to be passed to the C++ compiler.  Can be used multiple times."
+        action = :append_arg
+        arg_type = String
+    "--extraopt"
+        help = "Extra options to be passed to Bazel.  Can be used multiple times."
+        action = :append_arg
+        arg_type = String
 end
 #! format: on
 parsed_args = parse_args(ARGS, s)
@@ -44,27 +53,8 @@ for (k, v) in parsed_args
 end
 println()
 
-using Pkg, Scratch, Preferences, Libdl
-
-# 1. Get a scratch directory
-scratch_dir = get_scratch!(Reactant_jll, "build")
-isdir(scratch_dir) && rm(scratch_dir; recursive=true)
-
 source_dir = joinpath(@__DIR__, "ReactantExtra")
 
-# 2. Ensure that an appropriate LLVM_full_jll is installed
-Pkg.activate(; temp=true)
-
-# Build!
-@info "Building" source_dir scratch_dir
-run(`mkdir -p $(scratch_dir)`)
-run(
-    Cmd(
-        `$(Base.julia_cmd().exec[1]) --project=. -e "using Pkg; Pkg.instantiate()"`;
-        dir=source_dir,
-    ),
-)
-
 #--repo_env TF_NEED_ROCM=1
 #--define=using_rocm=true --define=using_rocm_hipcc=true
 #--action_env TF_ROCM_AMDGPU_TARGETS="gfx900,gfx906,gfx908,gfx90a,gfx1030"
@@ -115,21 +105,55 @@ gcc_host_compiler_path = parsed_args["gcc_host_compiler_path"]
 cc = parsed_args["cc"]
 hermetic_python_version = parsed_args["hermetic_python_version"]
 
+# Try to guess if `cc` is GCC and get its version number.
+cc_is_gcc, gcc_version = let
+    io = IOBuffer()
+    run(pipeline(ignorestatus(`$(cc) --version`); stdout=io))
+    version_string = String(take!(io))
+    # Detecing GCC is hard, the name "gcc" may not appear anywhere in the
+    # version string, but on the second line there should be FSF.
+    m = match(
+        r"\([^)]+\) (\d+\.\d+\.\d+).*\n.*Free Software Foundation, Inc\.",
+        version_string,
+    )
+    if !isnothing(m)
+        true, VersionNumber(m[1])
+    else
+        false, v"0"
+    end
+end
+
 build_cmd_list = [bazel_cmd, "build"]
 !isempty(arg) && push!(build_cmd_list, arg)
 append!(build_cmd_list, ["-c", "$(build_kind)"])
 push!(build_cmd_list, "--action_env=JULIA=$(Base.julia_cmd().exec[1])")
-if parsed_args["xnn_disable_avx512fp16"]
-    push!(build_cmd_list, "--define=xnn_enable_avx512fp16=false")
-end
-if parsed_args["xnn_disable_avxvnniint8"]
-    push!(build_cmd_list, "--define=xnn_enable_avxvnniint8=false")
-end
 push!(build_cmd_list, "--repo_env=HERMETIC_PYTHON_VERSION=$(hermetic_python_version)")
 push!(build_cmd_list, "--repo_env=GCC_HOST_COMPILER_PATH=$(gcc_host_compiler_path)")
 push!(build_cmd_list, "--repo_env=CC=$(cc)")
 push!(build_cmd_list, "--check_visibility=false")
 push!(build_cmd_list, "--verbose_failures")
+push!(build_cmd_list, "--jobs=$(parsed_args["jobs"])")
+for opt in parsed_args["copt"]
+    push!(build_cmd_list, "--copt=$(opt)")
+end
+for opt in parsed_args["cxxopt"]
+    push!(build_cmd_list, "--cxxopt=$(opt)")
+end
+for opt in parsed_args["extraopt"]
+    push!(build_cmd_list, opt)
+end
+# Some versions of GCC can't deal with some components of XLA, disable them if necessary.
+if cc_is_gcc && build_backend == "cuda"
+    arch = Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform())
+    if arch == "x86_64"
+        if gcc_version < v"13"
+            push!(build_cmd_list, "--define=xnn_enable_avxvnniint8=false")
+        end
+        if gcc_version < v"12"
+            push!(build_cmd_list, "--define=xnn_enable_avx512fp16=false")
+        end
+    end
+end
 push!(build_cmd_list, ":libReactantExtra.so")
 
 run(Cmd(Cmd(build_cmd_list); dir=source_dir))
@@ -158,7 +182,10 @@ if build_backend == "cuda"
         )
     end
 end
+
 # Tell ReactantExtra_jll to load our library instead of the default artifact one
+using Preferences
+
 set_preferences!(
     joinpath(dirname(@__DIR__), "LocalPreferences.toml"),
     "Reactant_jll",