Skip to content

Commit ea7b408

Browse files
Don't overload istraced check (#1341)
* Don't overload istraced check * types aren't traced * Update Project.toml * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 27842d3 commit ea7b408

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ Preferences = "1.4"
8686
PythonCall = "0.9"
8787
Random = "1.10"
8888
Random123 = "1.7"
89-
ReactantCore = "0.1.10"
90-
Reactant_jll = "0.0.189"
89+
ReactantCore = "0.1.11"
90+
Reactant_jll = "0.0.190"
9191
ScopedValues = "1.3.0"
9292
Scratch = "1.2"
9393
Sockets = "1.10"

lib/ReactantCore/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "ReactantCore"
22
uuid = "a3311ec8-5e00-46d5-b541-4f83e724a433"
33
authors = ["William Moses <[email protected]>", "Valentin Churavy <[email protected]>", "Sergio Sánchez Ramírez <[email protected]>", "Paul Berg <[email protected]>", "Avik Pal <[email protected]>"]
4-
version = "0.1.10"
4+
version = "0.1.11"
55

66
[deps]
77
ExpressionExplorer = "21656369-7473-754a-2065-74616d696c43"

lib/ReactantCore/src/ReactantCore.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ function is_traced((@nospecialize x::T), seen=Base.IdSet()) where {T}
1919
return false
2020
end
2121

22+
is_traced(T::Type) = false
23+
2224
# New Type signifying that a value is missing
2325
mutable struct MissingTracedValue
2426
paths::Tuple

src/utils.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@ function should_rewrite_call(@nospecialize(ft))
154154
ft === Type{MLIR.IR.Block} ||
155155
# TODO: perhaps problematic calls in `traced_call`
156156
# should be moved to TracedUtils.jl:
157-
ft <: typeof(Reactant.ReactantCore.traced_call)
157+
ft <: typeof(Reactant.ReactantCore.traced_call) ||
158+
ft <: typeof(ReactantCore.is_traced)
158159
return false
159160
end
160161

0 commit comments

Comments
 (0)