-
Notifications
You must be signed in to change notification settings - Fork 25
test: mark tests as broken instead of skipping them #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ea96f2
to
692a660
Compare
aba61b2
to
ba4b1b7
Compare
0edb57b
to
d7a3a67
Compare
01d07f5
to
b9ea1ae
Compare
1c2cf6b
to
0218fff
Compare
4c820ff
to
bf741ef
Compare
4c92135
to
d5ee6e0
Compare
d5ee6e0
to
137fb2d
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7f8f674
to
c2b8724
Compare
All tests are finally passing now 🎉 |
wsmoses
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip
orbroken
.skip
for ones which are not supported upstream andbroken
for cases we need to eventually fix