Skip to content

Commit 160c58e

Browse files
mcottontensormcottontensor
authored
Merge pull request #561 from mcottontensor/backport/UE5.5/pr-550
[UE5.5] Merge pull request #550 from mcottontensor/node_ver_actions
2 parents 73b1728 + c2b99a8 commit 160c58e

12 files changed

+68
-31
lines changed

‎.github/workflows/healthcheck-frontend.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-frontend.yml"
78
- "Common/**"
89
- "Frontend/**"
910
- "Signalling/**"
1011
- "SignallingWebServer/**"
1112
- "Extras/**"
1213
pull_request:
1314
paths:
15+
- ".github/workflows/healthcheck-frontend.yml"
1416
- "Common/**"
1517
- "Frontend/**"
1618
- "Signalling/**"

‎.github/workflows/healthcheck-image-sfu.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflow/healthcheck-image-sfu.yml"
78
- "SFU/**"
89
pull_request:
910
paths:
11+
- ".github/workflow/healthcheck-image-sfu.yml"
1012
- "SFU/**"
1113

1214
jobs:

‎.github/workflows/healthcheck-image-wilbur.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-image-wilbur.yml"
78
- "SignallingWebServer/**"
89
pull_request:
910
paths:
11+
- ".github/workflows/healthcheck-image-wilbur.yml"
1012
- "SignallingWebServer/**"
1113

1214
jobs:

‎.github/workflows/healthcheck-libraries.yml‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-libraries.yml"
78
- "Common/**"
89
- "Signalling/**"
910
- "SignallingWebServer/**"
@@ -12,16 +13,14 @@ on:
1213
- "Frontend/implementations/typescript/**"
1314
pull_request:
1415
paths:
16+
- ".github/workflows/healthcheck-libraries.yml"
1517
- "Common/**"
1618
- "Signalling/**"
1719
- "SignallingWebServer/**"
1820
- "Frontend/library/**"
1921
- "Frontend/ui-library/**"
2022
- "Frontend/implementations/typescript/**"
2123

22-
env:
23-
NODE_VERSION: 18.17.x
24-
2524
jobs:
2625
build-using-local-deps:
2726
if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
@@ -30,9 +29,13 @@ jobs:
3029
- name: Checkout source code
3130
uses: actions/checkout@v3
3231

32+
- name: Get node version
33+
id: get_node_version
34+
run: echo "node_version=$(cat NODE_VERSION)" >> $GITHUB_OUTPUT
35+
3336
- uses: actions/setup-node@v4
3437
with:
35-
node-version: "${{ env.NODE_VERSION }}"
38+
node-version: "${{ steps.get_node_version.outputs.node_version }}"
3639
registry-url: 'https://registry.npmjs.org'
3740

3841
- name: Clean build and lint checks on common library
@@ -61,4 +64,4 @@ jobs:
6164

6265
- name: Clean build of frontend implementation as ES6
6366
working-directory: Frontend/implementations/typescript
64-
run: npm install && npm run build:esm
67+
run: npm install && npm run build:esm

‎.github/workflows/healthcheck-libs-with-public-deps.yml‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88

99
env:
1010
commitsha: "${{ github.event.inputs.commitsha || github.sha }}"
11-
NODE_VERSION: 18.17.x
1211

1312
jobs:
1413
build-using-public-deps:
@@ -21,30 +20,36 @@ jobs:
2120
with:
2221
ref: "${{ env.commitsha }}"
2322

23+
- name: Get node version
24+
id: get_node_version
25+
run: echo "node_version=$(cat NODE_VERSION)" >> $GITHUB_OUTPUT
26+
2427
- uses: actions/setup-node@v4
2528
with:
26-
node-version: "${{ env.NODE_VERSION }}"
29+
node-version: "${{ steps.get_node_version.outputs.node_version }}"
2730
registry-url: 'https://registry.npmjs.org'
2831

2932
- name: Remove NPM workspaces
3033
run: rm package.json && rm package-lock.json
3134

35+
# Not linting or testing because some of those tools require the
36+
# workspace dependencies. eg. eslint and its plugins.
3237
- name: Build signalling using published packages only
3338
if: always()
3439
working-directory: Signalling
35-
run: npm install && npm run build && npm run lint
40+
run: npm install && npm run build
3641
- name: Build Wilbur using published packages only
3742
if: always()
3843
working-directory: SignallingWebServer
39-
run: npm install && npm run build && npm run lint
44+
run: npm install && npm run build
4045
- name: Build Frontend/library using published packages only
4146
if: always()
4247
working-directory: Frontend/library
43-
run: npm install && npm run build && npm run lint && npm run test
48+
run: npm install && npm run build
4449
- name: Build Frontend/ui-library using published packages only
4550
if: always()
4651
working-directory: Frontend/ui-library
47-
run: npm install && npm run build && npm run lint
52+
run: npm install && npm run build
4853
- name: Build Frontend/implementations/typescript using published packages only
4954
if: always()
5055
working-directory: Frontend/implementations/typescript

‎.github/workflows/healthcheck-platform-scripts.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-platform-scripts.yml"
78
- "SignallingWebServer/**"
89
pull_request:
910
paths:
11+
- ".github/workflows/healthcheck-platform-scripts.yml"
1012
- "SignallingWebServer/**"
1113

1214
jobs:

‎.github/workflows/healthcheck-signalling-protocol.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-signalling-protocol.yml"
78
- "Common/**"
89
- "Signalling/**"
910
- "SignallingWebServer/**"
1011
- "Extras/SS_Test/**"
1112
pull_request:
1213
paths:
14+
- ".github/workflows/healthcheck-signalling-protocol.yml"
1315
- "Common/**"
1416
- "Signalling/**"
1517
- "SignallingWebServer/**"

‎.github/workflows/healthcheck-streaming.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ on:
44
workflow_dispatch:
55
push:
66
paths:
7+
- ".github/workflows/healthcheck-streaming.yml"
78
- "Common/**"
89
- "Frontend/**"
910
- "Signalling/**"
1011
- "SignallingWebServer/**"
1112
- "Extras/**"
1213
pull_request:
1314
paths:
15+
- ".github/workflows/healthcheck-streaming.yml"
1416
- "Common/**"
1517
- "Frontend/**"
1618
- "Signalling/**"

‎.github/workflows/publish-common-library-to-npm.yml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ on:
55
branches: ['UE5.5']
66
paths: ['Common/package.json']
77

8-
env:
9-
NODE_VERSION: 18.17.x
10-
118
jobs:
129
build:
1310
if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
@@ -18,12 +15,19 @@ jobs:
1815
steps:
1916
- uses: actions/checkout@v4
2017
with:
21-
sparse-checkout: 'Common'
18+
sparse-checkout: |
19+
NODE_VERSION
20+
Common
2221
sparse-checkout-cone-mode: false
2322

23+
- name: Get node version
24+
working-directory: .
25+
id: get_node_version
26+
run: echo "node_version=$(cat NODE_VERSION)" >> $GITHUB_OUTPUT
27+
2428
- uses: actions/setup-node@v4
2529
with:
26-
node-version: "${{ env.NODE_VERSION }}"
30+
node-version: "${{ steps.get_node_version.outputs.node_version }}"
2731
registry-url: 'https://registry.npmjs.org'
2832
- run: npm install
2933
- run: npm run build

‎.github/workflows/publish-library-to-npm.yml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ on:
55
branches: ['UE5.5']
66
paths: ['Frontend/library/package.json']
77

8-
env:
9-
NODE_VERSION: 18.17.x
10-
118
jobs:
129
build:
1310
if: github.repository == 'EpicGamesExt/PixelStreamingInfrastructure'
@@ -18,12 +15,19 @@ jobs:
1815
steps:
1916
- uses: actions/checkout@v4
2017
with:
21-
sparse-checkout: 'Frontend/library'
18+
sparse-checkout: |
19+
NODE_VERSION
20+
Frontend/library
2221
sparse-checkout-cone-mode: false
2322

23+
- name: Get node version
24+
working-directory: .
25+
id: get_node_version
26+
run: echo "node_version=$(cat NODE_VERSION)" >> $GITHUB_OUTPUT
27+
2428
- uses: actions/setup-node@v4
2529
with:
26-
node-version: "${{ env.NODE_VERSION }}"
30+
node-version: "${{ steps.get_node_version.outputs.node_version }}"
2731
registry-url: 'https://registry.npmjs.org'
2832
- run: npm install
2933
- run: npm run build

0 commit comments

Comments
 (0)