Fixing more path issues in platform_scripts (#604)

* feat: Adding script tests where the scripts are run multiple times.

This tests that the scripts still work when things have already been
installed.

* fix: Fixing typo in github action.

* gimme a break.

* Adding mutliple script runs for other OSs

* Testing node on the runner

* Trying to figure out what node is doing what.

* Trying to change the way node version is detected.

* Messy

* The additions to the script really didn't catch anything. Could be worth
revisiting how we handle the local node install.

* Removing debug print.

Author: mcottontensor

.github/workflows/healthcheck-platform-scripts.yml

@@ -43,4 +43,3 @@ jobs:
         run: |
           Start-Process -NoNewWindow ".\platform_scripts\cmd\start.bat" -ArgumentList "--rest_api","--player_port 999"
           curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/api/status
-

SignallingWebServer/platform_scripts/bash/common.sh

@@ -168,6 +168,9 @@ function setup_node() {
     # navigate to project root
     pushd "${SCRIPT_DIR}/../../.." > /dev/null
 
+    # setup the path so we're using our node. required when calling npm
+    PATH="${SCRIPT_DIR}/node/bin:$PATH"
+
     node_version=""
     if [[ -f "${SCRIPT_DIR}/node/bin/node" ]]; then
         node_version=$("${SCRIPT_DIR}/node/bin/node" --version)
@@ -187,14 +190,13 @@ function setup_node() {
     else
         node_url="https://nodejs.org/dist/$NODE_VERSION/node-$NODE_VERSION-linux-x64.tar.gz"
     fi
-    check_and_install "node" "$node_version" "$NODE_VERSION" "curl $node_url --output node.tar.xz
+    check_and_install "${SCRIPT_DIR}/node/bin/node" "$node_version" "$NODE_VERSION" "curl $node_url --output node.tar.xz
                                                                 && tar -xf node.tar.xz
                                                                 && rm node.tar.xz
                                                                 && mv node-v*-*-* \"${SCRIPT_DIR}/node\""
 
     if [ $? -eq 1 ] || [ "$INSTALL_DEPS" == "1" ]; then
         echo "Installing dependencies..."
-        PATH="${SCRIPT_DIR}/node/bin:$PATH"
         "${NPM}" install
     fi