Merge pull request #558 from mcottontensor/backport/UE5.5/pr-543

[UE5.5] Merge pull request #543 from Belchy06/version

Author: mcottontensor

.github/workflows/create-gh-release.yml

@@ -45,9 +45,13 @@ jobs:
       id: getversion
       run: echo "version=$(cat RELEASE_VERSION)" >> $GITHUB_OUTPUT
 
+    - name: Get node version
+      id: get_node_version
+      run: echo "node_version=$(cat NODE_VERSION)" >> $Env:GITHUB_OUTPUT
+
     - uses: actions/setup-node@v3
       with:
-        node-version: '18.17.0'
+        node-version: ${{ steps.get_node_version.outputs.node_version }}
         registry-url: 'https://registry.npmjs.org'
 
     - name: Build common library

.github/workflows/healthcheck-frontend.yml

@@ -51,9 +51,13 @@ jobs:
   #   - name: Checkout source code
   #     uses: actions/checkout@v3
   #
+  #   - name: Get node version
+  #     id: get_node_version
+  #     run: echo "node_version=$(cat NODE_VERSION)" >> $Env:GITHUB_OUTPUT
+  #
   #   - uses: actions/setup-node@v4
   #     with:
-  #       node-version: 'v18.17.0'
+  #       node-version: ${{ steps.get_node_version.outputs.node_version }}
   #
   #   - name: Download streamer
   #     uses: robinraju/release-downloader@v1

.github/workflows/healthcheck-streaming.yml

@@ -52,9 +52,13 @@ jobs:
     - name: Checkout source code
       uses: actions/checkout@v3
 
+    - name: Get node version
+      id: get_node_version
+      run: echo "node_version=$(cat NODE_VERSION)" >> $Env:GITHUB_OUTPUT
+
     - uses: actions/setup-node@v4
       with:
-        node-version: 'v18.17.0'
+        node-version: ${{ steps.get_node_version.outputs.node_version }}
 
     - name: Download streamer
       uses: robinraju/release-downloader@v1
@@ -103,21 +107,22 @@ jobs:
         npm install
         npm run build
 
-    - name: Run Signalling
-      working-directory: SignallingWebServer
-      run: Start-Process "npm" -ArgumentList "run","start","--","--rest_api","--player_port 999","--http_root ${{ github.workspace }}\www"
-
-    - name: Run Streamer
-      working-directory: Streamer
-      run: Start-Process ".\Minimal\Binaries\Win64\Minimal-Cmd.exe" -ArgumentList "-warp","-dx12","-windowed","-resx=1920","-resy=720","-PixelStreamingURL=ws://localhost:8888","-RenderOffScreen","-AllowSoftwareRendering","-PixelStreamingEncoderCodec=vp8", "-Log=Minimal.log"
-
     - name: Prepare test
       working-directory: Extras\MinimalStreamTester
       run: |
         npm install
         npx playwright install --with-deps
         npx playwright install chrome
 
+    - name: Run Signalling
+      working-directory: SignallingWebServer
+      # triple hyphen for npm script running issues. With double the arguments get mangled
+      run: Start-Process powershell.exe -ArgumentList "npm","run","start","---","--rest_api","--player_port 999","--http_root ${{ github.workspace }}\www"
+
+    - name: Run Streamer
+      working-directory: Streamer
+      run: Start-Process ".\Minimal\Binaries\Win64\Minimal-Cmd.exe" -ArgumentList "-warp","-dx12","-windowed","-resx=1920","-resy=720","-PixelStreamingURL=ws://localhost:8888","-RenderOffScreen","-AllowSoftwareRendering","-PixelStreamingEncoderCodec=vp8", "-Log=Minimal.log"
+
     - name: Wait for signalling to come up
       run: curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/api/status
 

Extras/JSStreamer/Dockerfile

@@ -8,6 +8,7 @@ COPY /Extras/eslint/plugin-check-copyright ./Extras/eslint/plugin-check-copyrigh
 COPY /Common ./Common
 COPY /Extras/JSStreamer ./Extras/JSStreamer
 COPY ./package.json ./package.json
+COPY NODE_VERSION ./NODE_VERSION
 
 # Initiate NPM workspaces so we can install deps like our common lib using local built packages as opposed to remove published packages
 RUN npm install

Extras/MinimalStreamTester/dockerfiles/windows/Dockerfile

@@ -1,15 +1,24 @@
+# escape=`
+
 FROM mcr.microsoft.com/windows:ltsc2019
 
 SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';$ProgressPreference='silentlyContinue';"]
 
-RUN Invoke-WebRequest -OutFile nodejs.zip -UseBasicParsing "https://nodejs.org/dist/v18.17.0/node-v18.17.0-win-x64.zip"; Expand-Archive nodejs.zip -DestinationPath C:\; Rename-Item "C:\\node-v18.17.0-win-x64" c:\nodejs
+WORKDIR C:/tester
+COPY NODE_VERSION .
+
+RUN $node_version = Get-Content NODE_VERSION -Raw; `
+    Invoke-WebRequest -OutFile nodejs.zip -UseBasicParsing "https://nodejs.org/dist/$node_version/node-$node_version-win-x64.zip"; `
+    Expand-Archive nodejs.zip -DestinationPath C:\; `
+    Rename-Item "C:\node-$node_version-win-x64" c:\nodejs
+
+RUN Set-ExecutionPolicy -ExecutionPolicy Unrestricted
 
 RUN setx /M PATH \"$Env:PATH;C:\nodejs\"
 
 RUN npm config set registry https://registry.npmjs.org/
 
 # Copy the signalling server and frontend source code from the build context
-WORKDIR C:/tester
 COPY /Extras/MinimalStreamTester .
 
 # Install the dependencies for the signalling server and build the frontend

Extras/SS_Test/Dockerfile

@@ -1,7 +1,8 @@
-FROM node:18.17.0 as builder
+FROM node:22.14.0 as builder
 
 WORKDIR /SignallingTester
 
+COPY NODE_VERSION ./NODE_VERSION
 COPY package.json ./package.json
 COPY Common/ ./Common
 COPY Extras/SS_Test/ ./Extras/SS_Test

Frontend/README.md

@@ -39,10 +39,10 @@ If part of the library is not exposed and you wish to extend it, please do so in
 
 ## Developing
 
-⚠️ Only NodeJS LTS 18.17.0 is officially supported, some newer versions on NodeJS **WILL BREAK YOUR BUILD** ⚠️
+⚠️ Only NodeJS LTS 22.14.0 is officially supported, some newer versions on NodeJS **WILL BREAK YOUR BUILD** ⚠️
 
 ### Prerequisites for local dev
-- Install NodeJS LTS 18.17.0 on your system.
+- Install NodeJS LTS 22.14.0 on your system.
 - Install npm globally using: `npm install npm -g` (yes this is required)
 
 ### Building the Library

NODE_VERSION

@@ -0,0 +1 @@
+v22.14.0

SFU/Dockerfile

@@ -1,6 +1,7 @@
 # Use the current Long Term Support (LTS) version of Node.js
 FROM node:lts
 
+COPY NODE_VERSION ./NODE_VERSION
 COPY /SFU /SFU
 
 RUN SFU/platform_scripts/bash/setup.sh

SFU/platform_scripts/bash/Dockerfile

@@ -7,6 +7,7 @@ RUN apt -y update
 RUN apt -y install python3-pip
 
 # Copy the Selective Forwarding Unit (SFU) to the Docker build context
+COPY ../NODE_VERSION /opt/NODE_VERSION
 COPY . /opt/SFU
 
 # Install the dependencies for the mediasoup server