eliminate unnecessary complication for debugger query evaluations; formalize them in the schemas, use set-hook rule to automatically plug in querying functions for them

Author: ryanfleury

src/eval/eval_ir.c

@@ -221,6 +221,7 @@ E_LOOKUP_ACCESS_FUNCTION_DEF(default)
       B32 r_found = 0;
       E_TypeKey r_type = zero_struct;
       U64 r_value = 0;
+      String8 r_query_name = {0};
       B32 r_is_constant_value = 0;
       {
         Temp scratch = scratch_begin(&arena, 1);
@@ -231,6 +232,10 @@ E_LOOKUP_ACCESS_FUNCTION_DEF(default)
           r_type = match.type_key;
           r_value = match.off;
         }
+        if(match.kind == E_MemberKind_Query)
+        {
+          r_query_name = exprr->string;
+        }
         if(match.kind == E_MemberKind_Null)
         {
           E_Type *type = e_type_from_key__cached(check_type_key);
@@ -290,6 +295,7 @@ E_LOOKUP_ACCESS_FUNCTION_DEF(default)
       {
         // rjf: build tree
         E_IRNode *new_tree = l.root;
+        E_TypeKey new_tree_type = r_type;
         E_Mode mode = l.mode;
         if(l_restype_kind == E_TypeKind_Ptr ||
            l_restype_kind == E_TypeKind_LRef ||
@@ -625,7 +631,7 @@ E_IRGEN_FUNCTION_DEF(slice)
       E_TypeKey sized_base_ptr_type_key = e_type_key_cons_ptr(e_type_state->ctx->primary_module->arch, element_type_key, count, 0);
       E_MemberList slice_type_members = {0};
       e_member_list_push(scratch.arena, &slice_type_members, count_member);
-      e_member_list_push(scratch.arena, &slice_type_members, &(E_Member){.kind = E_MemberKind_DataField, .type_key = sized_base_ptr_type_key, .name = base_ptr_member->name, .pretty_name = base_ptr_member->pretty_name, .off = base_ptr_member->off});
+      e_member_list_push(scratch.arena, &slice_type_members, &(E_Member){.kind = E_MemberKind_DataField, .type_key = sized_base_ptr_type_key, .name = base_ptr_member->name, .off = base_ptr_member->off});
       E_MemberArray slice_type_members_array = e_member_array_from_list(scratch.arena, &slice_type_members);
       slice_type_key = e_type_key_cons(.arch = e_type_state->ctx->primary_module->arch,
                                        .kind = E_TypeKind_Struct,

src/eval/eval_types.c

@@ -501,7 +501,7 @@ e_type_key_cons_base(Type *type)
       for(U64 idx = 0; idx < type->count; idx += 1)
       {
         E_TypeKey member_type_key = e_type_key_cons_base(type->members[idx].type);
-        e_member_list_push_new(scratch.arena, &members, .name = type->members[idx].name, .off = type->members[idx].value, .type_key = member_type_key, .pretty_name = type->members[idx].pretty_name);
+        e_member_list_push_new(scratch.arena, &members, .name = type->members[idx].name, .off = type->members[idx].value, .type_key = member_type_key);
       }
       E_MemberArray members_array = e_member_array_from_list(scratch.arena, &members);
       result = e_type_key_cons(.arch    = arch_from_context(),
@@ -1413,7 +1413,6 @@ e_type_member_copy(Arena *arena, E_Member *src)
   E_Member *dst = push_array(arena, E_Member, 1);
   MemoryCopyStruct(dst, src);
   dst->name = push_str8_copy(arena, src->name);
-  dst->pretty_name = push_str8_copy(arena, src->pretty_name);
   dst->inheritance_key_chain = e_type_key_list_copy(arena, &src->inheritance_key_chain);
   return dst;
 }

src/eval/eval_types.h

@@ -59,6 +59,7 @@ typedef enum E_MemberKind
   E_MemberKind_VirtualBase,
   E_MemberKind_NestedType,
   E_MemberKind_Padding,
+  E_MemberKind_Query,
   E_MemberKind_COUNT
 }
 E_MemberKind;
@@ -80,7 +81,6 @@ struct E_Member
   E_MemberKind kind;
   E_TypeKey type_key;
   String8 name;
-  String8 pretty_name;
   U64 off;
   E_TypeKeyList inheritance_key_chain;
 };

src/raddbg/generated/raddbg.meta.c

@@ -296,15 +296,15 @@ RD_VocabInfo rd_vocab_info_table[285] =
 RD_NameSchemaInfo rd_name_schema_info_table[10] =
 {
 {str8_lit_comp("settings"), str8_lit_comp("x:\n{\n  @default(1) 'hover_animations':     bool,\n  @default(1) 'press_animations':     bool,\n  @default(0) 'focus_animations':     bool,\n  @default(1) 'tooltip_animations':   bool,\n  @default(1) 'menu_animations':      bool,\n  @default(1) 'scrolling_animations': bool,\n  @default(1) 'background_blur':      bool,\n  @default(1) 'thread_lines':         bool,\n  @default(1) 'breakpoint_lines':     bool,\n  @default(1) 'thread_glow':          bool,\n  @default(1) 'breakpoint_glow':      bool,\n  @default(0) 'opaque_backgrounds':   bool,\n  @default(1) 'smooth_main_text':     bool,\n  @default(0) 'smooth_code_text':     bool,\n  @default(1) 'hint_main_text':       bool,\n  @default(1) 'hint_code_text':       bool,\n  @default(2) 'tab_width':      @range[1, 32] u64,\n  @can_be_per_window 'main_font_size': @range[6, 72] u64,\n  @can_be_per_window 'code_font_size': @range[1, 32] u64,\n}\n")},
-{str8_lit_comp("target"), str8_lit_comp("@commands(launch_and_run, launch_and_init, select_cfg, remove_cfg)\n@collection_commands(add_target)\nx:\n{\n  'label':              code_string,\n  'executable':         path,\n  'arguments':          string,\n  'working_directory':  path,\n  'entry_point':        code_string,\n  'stdout_path':        path,\n  'stderr_path':        path,\n  'stdin_path':         path,\n  'debug_subprocesses': bool,\n}\n")},
+{str8_lit_comp("target"), str8_lit_comp("@commands(launch_and_run, launch_and_init, select_cfg, remove_cfg)\n@collection_commands(add_target)\nx:\n{\n  'label':              code_string,\n  'executable':         path,\n  'arguments':          string,\n  'working_directory':  path,\n  'entry_point':        code_string,\n  'stdout_path':        path,\n  'stderr_path':        path,\n  'stdin_path':         path,\n  'debug_subprocesses': bool,\n  'environment':        query,\n}\n")},
 {str8_lit_comp("breakpoint"), str8_lit_comp("@commands(enable_cfg, remove_cfg)\n@collection_commands(add_breakpoint, add_address_breakpoint, add_function_breakpoint)\nx:\n{\n  'label':         code_string,\n  'condition':     code_string,\n  'location':      location,\n  'hit_count':     u64,\n  'disabled':      bool,\n}\n")},
 {str8_lit_comp("watch_pin"), str8_lit_comp("@commands(remove_cfg)\n@collection_commands(add_watch_pin)\nx:\n{\n  'expression': code_string,\n  'view_rule':  code_string,\n  'location':   location,\n}\n")},
 {str8_lit_comp("file_path_map"), str8_lit_comp("@collection_commands(add_file_path_map) @commands(remove_cfg) x:{'source':path, 'dest':path}")},
 {str8_lit_comp("auto_view_rule"), str8_lit_comp("@collection_commands(add_auto_view_rule) @commands(remove_cfg) x:{'source':code_string, 'dest':code_string}")},
-{str8_lit_comp("machine"), str8_lit_comp("x:{'frozen':bool, 'label':code_string}")},
-{str8_lit_comp("process"), str8_lit_comp("x:{'frozen':bool, 'label':code_string, 'id':u64}")},
+{str8_lit_comp("machine"), str8_lit_comp("x:{'label':code_string, 'frozen':bool, 'processes':query}")},
+{str8_lit_comp("process"), str8_lit_comp("x:{'label':code_string, 'id':u64, 'frozen':bool, 'modules':query, 'threads':query}")},
 {str8_lit_comp("module"), str8_lit_comp("x:{'exe':path, 'dbg':path, 'vaddr_range':vaddr_range}")},
-{str8_lit_comp("thread"), str8_lit_comp("x:{'frozen':bool, 'label':code_string, 'id':u64}")},
+{str8_lit_comp("thread"), str8_lit_comp("x:{'label':code_string, 'id':u64, 'frozen':bool, 'call_stack':query}")},
 };
 
 Rng1U64 rd_reg_slot_range_table[38] =

src/raddbg/raddbg.mdesk

@@ -159,6 +159,7 @@ RD_VocabTable:
       'stderr_path':        path,
       'stdin_path':         path,
       'debug_subprocesses': bool,
+      'environment':        query,
     }
     ```,
   }
@@ -210,13 +211,13 @@ RD_VocabTable:
   //- rjf: machines
   {
     machine,
-    ```x:{'frozen':bool, 'label':code_string}```,
+    ```x:{'label':code_string, 'frozen':bool, 'processes':query}```,
   }
 
   //- rjf: processes
   {
     process,
-    ```x:{'frozen':bool, 'label':code_string, 'id':u64}```,
+    ```x:{'label':code_string, 'id':u64, 'frozen':bool, 'modules':query, 'threads':query}```,
   }
 
   //- rjf: modules
@@ -228,7 +229,7 @@ RD_VocabTable:
   //- rjf: threads
   {
     thread,
-    ```x:{'frozen':bool, 'label':code_string, 'id':u64}```,
+    ```x:{'label':code_string, 'id':u64, 'frozen':bool, 'call_stack':query}```,
   }
 }