Add rules text to a bunch more mods

Author: EpicOrange

documentation/documentation.md

@@ -646,8 +646,8 @@ Colors are specified as CSS color strings like `"#808080"` or `"lightblue"`. Exa
 - `["noop"]`: does nothing, but you can put it in `interruptible_actions` to make it an interrupt.
 - `["push_message", message]`: Sends a message to all players using the current player as a label. Example: `["push_message", "declared riichi"]`
 - `["push_system_message", message]`: Sends a message to all players, with no label. Example: `["push_system_message", "Converted each shuugi to 2000 points."]`
-- `["add_rule", title, text, priority]`: Adds the string `text` to the rules tab on the left. Keep it brief! `title` is a required string identifier that is also used for deleting this rule later -- you can also specify an existing identifier to append `text` to that rule. `priority` is an optional integer argument that defaults to `0` -- the rules on the rules list are sorted from highest priority to lowest.
-- `["update_rule", title, text, priority]`: Same as `"add_rule"`, but only appends text (does nothing if the rule `title` does not exist).
+- `["add_rule", title, text, sort_order]`: Adds the string `text` to the rules tab on the left. Keep it brief! `title` is a required string identifier that is also used for deleting this rule later -- you can also specify an existing identifier to append a `text` to that rule (on its own line). `sort_order` is an optional integer argument that defaults to `0` -- the rules on the rules list are sorted from lowest `sort_order` to highest.
+- `["update_rule", title, text, sort_order]`: Same as `"add_rule"`, but only appends `text` (does nothing if the rule `title` does not exist).
 - `["delete_rule", title]`: Deletes the rule text identified by `title`.
 - `["run", fn_name, {"arg1": "value1", ...}]`: Call the given function with the given arguments. A function is essentially a named list of actions. Functions are defined in the toplevel `"functions"` key -- see `riichi.json` for examples. Within a function you may write variables preceded with a dollar sign -- like `$arg1` -- and the value will be replaced with the corresponding `value1` in the (optional) given object. Functions can be called recursively, but this is rarely done, and therefore there is an arbitrary call stack limit of 10 calls.
 - `["draw", num, tile]`: Draw `num` tiles. If `tile` is specified, it draws that tile instead of from the wall. Instead of a tile for `tile` you may instead write `"opposite_end"` to draw from the opposite end of the wall (i.e. the dead wall, if one exists)

lib/riichi_advanced/game/game_state/actions.ex

@@ -799,13 +799,13 @@ defmodule RiichiAdvanced.GameState.Actions do
         id = Enum.at(opts, 0, "")
         text = Enum.at(opts, 1, "")
         priority = Enum.at(opts, 2, nil)
-        update_in(state.rules_text, &Map.update(&1, id, {text, if priority == nil do 0 else priority end}, fn {orig_text, orig_priority} -> {orig_text <> text, if priority == nil do orig_priority else priority end} end))
+        update_in(state.rules_text, &Map.update(&1, id, {text, if priority == nil do 0 else priority end}, fn {orig_text, orig_priority} -> {orig_text <> "\n" <> text, if priority == nil do orig_priority else priority end} end))
       "update_rule"             ->
         id = Enum.at(opts, 0, "")
         if Map.has_key?(state.rules_text, id) do
           text = Enum.at(opts, 1, "")
           priority = Enum.at(opts, 2, nil)
-          update_in(state.rules_text, &Map.update!(&1, id, fn {orig_text, orig_priority} -> {orig_text <> text, if priority == nil do orig_priority else priority end} end))
+          update_in(state.rules_text, &Map.update!(&1, id, fn {orig_text, orig_priority} -> {orig_text <> "\n" <> text, if priority == nil do orig_priority else priority end} end))
         else state end
       "delete_rule"             ->
         id = Enum.at(opts, 0, "")

lib/riichi_advanced_web/views/game_live.ex

@@ -355,7 +355,7 @@ defmodule RiichiAdvancedWeb.GameLive do
       <label for="rules-popover-checkbox">Rules</label>
       <div class="rules-popover-container" :if={not Enum.empty?(@state.rules_text)}>
         <div class="rules-popover">
-          <%= for {title, {text, _priority}} <- Enum.sort_by(@state.rules_text, fn {title, {_text, priority}} -> {priority, title} end) do %>
+          <%= for {title, {text, _priority}} <- Enum.sort_by(@state.rules_text, fn {_title, {text, priority}} -> {priority, String.length(text)} end) do %>
             <div class="rules-popover-rule">
               <div class="rules-popover-title"><%= title %></div>
               <div class="rules-popover-text"><%= text %></div>

priv/static/mods/agarirenchan.jq

@@ -1,6 +1,6 @@
 .after_initialization.actions += [
   ["add_rule", "Agarirenchan", "If the dealer (East wind) wins, the round repeats."],
-  ["update_rule", "Honba", " One honba stick is also added if the dealer (East wind) wins."]
+  ["update_rule", "Honba", "(Agarirenchan) One honba stick is also added if the dealer (East wind) wins."]
 ]
 |
 .score_calculation.agarirenchan = true

priv/static/mods/agariyame.jq

@@ -1,3 +1,3 @@
-.after_initialization.actions += [["add_rule", "Agarirenchan", " Agariyame: An exception is if it's the last round and the winning dealer becomes first place -- then the game just ends."]]
+.after_initialization.actions += [["update_rule", "Agarirenchan", "(Agariyame) An exception is if it's the last round and the winning dealer becomes first place -- then the game just ends."]]
 |
 .agariyame = true

priv/static/mods/aka.jq

@@ -9,6 +9,8 @@ def replace_n_tiles($tile; $aka; $num):
     else . end
   else . end;
 
+.after_initialization.actions += [["add_rule", "Aka", "\($man)x 5m, \($pin)x 5p, and \($sou)x 5p are replaced with red \"aka dora\" fives that are worth one extra han each."]]
+|
 # replace 5m,5p,5s in wall with 0m,0p,0s
 .wall |= replace_n_tiles("5m"; "0m"; $man)
 |

priv/static/mods/ao.jq

@@ -9,6 +9,8 @@ def replace_n_tiles($tile; $aka; $num):
     else . end
   else . end;
 
+.after_initialization.actions += [["add_rule", "Ao", "\($man)x 5m, \($pin)x 5p, and \($sou)x 5p are replaced with blue \"ao dora\" fives that are worth two extra han each."]]
+|
 # replace 5m,5p,5s in wall with 25m,25p,25s
 .wall |= replace_n_tiles("5m"; "25m"; $man)
 |

priv/static/mods/aotenjou.jq

@@ -1,3 +1,5 @@
+.after_initialization.actions += [["add_rule", "Aotenjou", "Limit hands are removed. Scores are calculated with the standard han-fu formula: a standard nondealer ron is worth 4 * fu * 2^(2+han), rounded up to the nearest \(.score_calculation.han_fu_rounding_factor // 100)."]]
+|
 .score_calculation.limit_thresholds = []
 |
 .score_e_notation = true

priv/static/mods/dora.jq

@@ -1,3 +1,5 @@
+.after_initialization.actions += [["add_rule", "Dora", "At the beginning of the game, \($start_indicators) dora indicators are revealed in the dead wall. The tile next in sequence to a dora indicator is considered dora, and each copy of dora in hand is worth 1 extra han."]]
+|
 .max_revealed_tiles = 5
 |
 # initial dora flip

priv/static/mods/double_round_wind.jq

@@ -1,3 +1,5 @@
+.after_initialization.actions += [["add_rule", "Double Round Wind", "Opposing winds are also round winds. So in East round, West is also a round wind."]]
+|
 .yaku += [{
   "display_name": "Round Wind",
   "value": 1,