Skip to content

Commit 9707f4d

Browse files
committed
Fix test cases and add check for existing fact
1 parent 9de64c9 commit 9707f4d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

eppo_metrics_sync/validation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ def valid_guardrail_cutoff_signs(payload):
9494
facts[fact['name']] = fact
9595

9696
for m in payload.metrics:
97-
numerator_fact = facts[m['numerator']['fact_name']]
98-
if is_guardrail_cutoff_exist(m) and 'desired_change' in numerator_fact:
99-
error = is_valid_guardrail_cutoff_sign(m, numerator_fact)
97+
numerator_fact_name = m['numerator']['fact_name']
98+
if is_guardrail_cutoff_exist(m) and numerator_fact_name in facts and 'desired_change' in facts[numerator_fact_name]:
99+
error = is_valid_guardrail_cutoff_sign(m, facts[numerator_fact_name])
100100
if error:
101101
payload.validation_errors.append(
102102
f"{m['name']} is having invalid guardrail_cutoff sign: {error}"

0 commit comments

Comments
 (0)