Skip to content

Commit cf932c2

Browse files
committed
Add type property to metric schema and update guardrail_cutoff to allow NULL values
1 parent 4b78473 commit cf932c2

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

eppo_metrics_sync/schema/eppo_metric_schema.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"description": "User-friendly description of the fact",
7272
"type": "string"
7373
},
74-
"desired_change" : {
74+
"desired_change": {
7575
"description": "Specify whether or not increases in the fact are desired",
7676
"enum": ["increase", "decrease"]
7777
}
@@ -124,6 +124,10 @@
124124
"description": "A user-friendly description of the fact",
125125
"type": "string"
126126
},
127+
"type": {
128+
"description": "The kind of metric to be calculated",
129+
"enum": ["simple", "ratio", "funnel", "percentile"]
130+
},
127131
"entity": {
128132
"description": "Must exactly match entity's name in Eppo UI",
129133
"type": "string"
@@ -146,7 +150,7 @@
146150
},
147151
"guardrail_cutoff": {
148152
"description": "If a metric is expected to increase, this value should be negative, to warn when the metric is decreasing by more than this value.",
149-
"type": "number"
153+
"type": ["number", "null"]
150154
},
151155
"numerator": {
152156
"description": "Specify how the numerator of this metric should be aggregated",

0 commit comments

Comments
 (0)