Add to schema with test

Author: chasdevs

eppo_metrics_sync/schema/eppo_metric_schema.json

@@ -156,7 +156,7 @@
                             },
                             "operation": {
                                 "description": "Which aggregation to apply to the fact",
-                                "enum": ["sum", "count", "distinct_entity", "threshold", "conversion", "retention", "count_distinct"]
+                                "enum": ["sum", "count", "distinct_entity", "threshold", "conversion", "retention", "count_distinct", "last_value", "first_value"]
                             },
                             "filters": {
                                 "description": "Optional fact property filters to apply",
@@ -254,7 +254,7 @@
                             },
                             "operation": {
                                 "description": "How to aggregate fact",
-                                "enum": ["sum", "count", "distinct_entity", "count_distinct"]
+                                "enum": ["sum", "count", "distinct_entity", "count_distinct", "last_value", "first_value"]
                             },
                             "filters": {
                                 "description": "Optional fact property filters to apply",

tests/test_validation.py

@@ -137,3 +137,8 @@ def test_last_value():
 def test_first_value():
     res = aggregation_is_valid({'operation': 'first_value'})
     assert res == None
+
+def test_valid_yaml():
+    eppo_metrics_sync = EppoMetricsSync(directory=None)
+    eppo_metrics_sync.load_eppo_yaml(path='tests/yaml/valid/purchases.yaml')
+    eppo_metrics_sync.validate()

tests/yaml/valid/purchases.yaml

@@ -52,4 +52,10 @@ metrics:
         operation: equals
         values:
           - "UNITED STATES"
-
+- name: Last Purchase Amount
+  description: The last purchase amount with winsorization
+  numerator:
+    fact_name: Purchase
+    operation: last_value
+    winsorization_lower_percentile: 0.05
+    winsorization_upper_percentile: 0.95