Skip to content

Commit 1732d6b

Browse files
authored
Bugfix/assignment logger interface (#12)
* Add README so that package info on pkg.go.dev will be shown more nicely * Fixes for assignmentLogger (config must have interface as type) * Fix
1 parent 012f657 commit 1732d6b

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ It is used to retrieve the experiments data and put it to in-memory cache, and t
88
Refer to our [SDK documentation](https://docs.geteppo.com/prerequisites/feature-flagging/randomization-sdk/) for how to install and use the SDK.
99

1010
## Supported Python Versions
11-
This version of the SDK is compatible with Python 3.6 and above.
11+
This version of the SDK is compatible with Go v1.18 and above.
1212

1313
## Example
1414

eppoclient/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const default_base_url = "https://eppo.cloud/api"
55
type Config struct {
66
BaseUrl string
77
ApiKey string
8-
AssignmentLogger AssignmentLogger
8+
AssignmentLogger IAssignmentLogger
99
}
1010

1111
func (cfg *Config) validate() {

eppoclient/eppoclient_e2e_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ var tstData = []testData{}
2828
func Test_e2e(t *testing.T) {
2929
serverUrl := initFixture()
3030

31-
client := InitClient(Config{BaseUrl: serverUrl, ApiKey: "dummy", AssignmentLogger: AssignmentLogger{}})
31+
asmntLogger := &AssignmentLogger{}
32+
client := InitClient(Config{BaseUrl: serverUrl, ApiKey: "dummy", AssignmentLogger: asmntLogger})
3233

3334
time.Sleep(2 * time.Second)
3435

0 commit comments

Comments
 (0)