fix(LruAssignmentLogger): always log latest assignment (#52)

Author: rasendubi

eppoclient/lruassignmentlogger.go

@@ -14,12 +14,12 @@ type LruAssignmentLogger struct {
 // knowing the latest assignment. Therefore, both allocation and
 // variation are part of the cacheKey.
 type cacheKey struct {
-	flag       string
-	subject    string
-	allocation string
-	variation  string
+	flag    string
+	subject string
 }
 type cacheValue struct {
+	allocation string
+	variation  string
 }
 
 func NewLruAssignmentLogger(logger IAssignmentLogger, cacheSize int) IAssignmentLogger {
@@ -37,12 +37,13 @@ func NewLruAssignmentLogger(logger IAssignmentLogger, cacheSize int) IAssignment
 
 func (self *LruAssignmentLogger) LogAssignment(event AssignmentEvent) {
 	key := cacheKey{
-		flag:       event.FeatureFlag,
-		subject:    event.Subject,
+		flag:    event.FeatureFlag,
+		subject: event.Subject,
+	}
+	value := cacheValue{
 		allocation: event.Allocation,
 		variation:  event.Variation,
 	}
-	value := cacheValue{}
 	previousValue, recentlyLogged := self.cache.Get(key)
 	if !recentlyLogged || previousValue != value {
 		self.inner.LogAssignment(event)

eppoclient/lruassignmentlogger_test.go

@@ -139,7 +139,7 @@ func Test_LruAssignmentLogger_changeInVariationCausesLogging(t *testing.T) {
 	innerLogger.AssertNumberOfCalls(t, "LogAssignment", 2)
 }
 
-func Test_LruAssignmentLogger_allocationOscillationOnlyLoggedOnce(t *testing.T) {
+func Test_LruAssignmentLogger_allocationOscillationLogsAll(t *testing.T) {
 	innerLogger := new(mockLogger)
 	innerLogger.On("LogAssignment", mock.Anything).Return()
 
@@ -182,10 +182,10 @@ func Test_LruAssignmentLogger_allocationOscillationOnlyLoggedOnce(t *testing.T)
 		SubjectAttributes: Attributes{"testKey": "testValue"},
 	})
 
-	innerLogger.AssertNumberOfCalls(t, "LogAssignment", 2)
+	innerLogger.AssertNumberOfCalls(t, "LogAssignment", 4)
 }
 
-func Test_LruAssignmentLogger_variationOscillationOnlyLoggedOnce(t *testing.T) {
+func Test_LruAssignmentLogger_variationOscillationLogsAll(t *testing.T) {
 	innerLogger := new(mockLogger)
 	innerLogger.On("LogAssignment", mock.Anything).Return()
 
@@ -228,5 +228,5 @@ func Test_LruAssignmentLogger_variationOscillationOnlyLoggedOnce(t *testing.T) {
 		SubjectAttributes: Attributes{"testKey": "testValue"},
 	})
 
-	innerLogger.AssertNumberOfCalls(t, "LogAssignment", 2)
+	innerLogger.AssertNumberOfCalls(t, "LogAssignment", 4)
 }