linter

Author: aarsilv

src/main/java/com/eppo/sdk/EppoClient.java

@@ -5,11 +5,10 @@
 import cloud.eppo.logging.BanditLogger;
 import com.eppo.sdk.helpers.AppDetails;
 import com.eppo.sdk.helpers.FetchConfigurationsTask;
+import java.util.Timer;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Timer;
-
 public class EppoClient extends BaseEppoClient {
   private static final Logger log = LoggerFactory.getLogger(EppoClient.class);
 
@@ -30,15 +29,15 @@ public static EppoClient getInstance() {
   }
 
   private EppoClient(
-    String apiKey,
-    String host,
-    String sdkName,
-    String sdkVersion,
-    AssignmentLogger assignmentLogger,
-    BanditLogger banditLogger,
-    boolean isGracefulModel
-  ) {
-    super(apiKey, host, sdkName, sdkVersion, assignmentLogger, banditLogger, isGracefulModel, false);
+      String apiKey,
+      String host,
+      String sdkName,
+      String sdkVersion,
+      AssignmentLogger assignmentLogger,
+      BanditLogger banditLogger,
+      boolean isGracefulModel) {
+    super(
+        apiKey, host, sdkName, sdkVersion, assignmentLogger, banditLogger, isGracefulModel, false);
   }
 
   public static void stopPolling() {
@@ -98,26 +97,30 @@ public EppoClient buildAndInit() {
 
       if (instance != null) {
         if (forceReinitialize) { // TODO: unit test this
-          log.warn("Eppo SDK is already initialized, reinitializing since forceReinitialize is true");
+          log.warn(
+              "Eppo SDK is already initialized, reinitializing since forceReinitialize is true");
         } else {
-          log.warn("Eppo SDK is already initialized, skipping reinitialization since forceReinitialize is false");
+          log.warn(
+              "Eppo SDK is already initialized, skipping reinitialization since forceReinitialize is false");
           return instance;
         }
       }
 
-      instance = new EppoClient(apiKey, sdkName, sdkVersion, host, assignmentLogger, banditLogger, isGracefulMode);
+      instance =
+          new EppoClient(
+              apiKey, sdkName, sdkVersion, host, assignmentLogger, banditLogger, isGracefulMode);
 
       // Stop any active polling
       stopPolling();
 
       // Set up polling for experiment configurations
       pollTimer = new Timer(true);
       FetchConfigurationsTask fetchConfigurationsTask =
-        new FetchConfigurationsTask(
-          () -> instance.loadConfiguration(),
-          pollTimer,
-          pollingIntervalMs,
-          pollingIntervalMs / DEFAULT_JITTER_INTERVAL_RATIO);
+          new FetchConfigurationsTask(
+              () -> instance.loadConfiguration(),
+              pollTimer,
+              pollingIntervalMs,
+              pollingIntervalMs / DEFAULT_JITTER_INTERVAL_RATIO);
 
       // Kick off the first fetch
       fetchConfigurationsTask.run();

src/main/java/com/eppo/sdk/helpers/FetchConfigurationsTask.java

@@ -2,7 +2,6 @@
 
 import java.util.Timer;
 import java.util.TimerTask;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -14,10 +13,7 @@ public class FetchConfigurationsTask extends TimerTask {
   private final long jitterInMillis;
 
   public FetchConfigurationsTask(
-      Runnable runnable,
-      Timer timer,
-      long intervalInMillis,
-      long jitterInMillis) {
+      Runnable runnable, Timer timer, long intervalInMillis, long jitterInMillis) {
     this.runnable = runnable;
     this.timer = timer;
     this.intervalInMillis = intervalInMillis;

src/main/java/com/eppo/sdk/helpers/IPollerTask.java

@@ -0,0 +1 @@
+

src/test/java/com/eppo/sdk/EppoClientTest.java

@@ -22,14 +22,12 @@
 import com.github.tomakehurst.wiremock.client.WireMock;
 import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
 import java.io.File;
-
 import java.lang.reflect.Field;
 import java.util.stream.Stream;
-
 import org.apache.commons.io.FileUtils;
+import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -45,7 +43,8 @@ public class EppoClientTest {
   private static WireMockServer mockServer;
 
   private static final String DUMMY_FLAG_API_KEY = "dummy-flags-api-key"; // Will load flags-v1
-  private static final String DUMMY_BANDIT_API_KEY = "dummy-bandits-api-key"; // Will load bandit-flags-v1
+  private static final String DUMMY_BANDIT_API_KEY =
+      "dummy-bandits-api-key"; // Will load bandit-flags-v1
   private AssignmentLogger mockAssignmentLogger;
   private BanditLogger mockBanditLogger;
 
@@ -55,20 +54,21 @@ public static void initMockServer() {
     mockServer.start();
 
     // If we get the dummy flag API key, return flags-v1.json
-    String ufcFlagsResponseJson =
-        readConfig(
-            "src/test/resources/shared/ufc/flags-v1.json");
+    String ufcFlagsResponseJson = readConfig("src/test/resources/shared/ufc/flags-v1.json");
     mockServer.stubFor(
-        WireMock.get(WireMock.urlMatching(".*flag-config/v1/config\\?.*apiKey="+DUMMY_FLAG_API_KEY+".*"))
+        WireMock.get(
+                WireMock.urlMatching(
+                    ".*flag-config/v1/config\\?.*apiKey=" + DUMMY_FLAG_API_KEY + ".*"))
             .willReturn(WireMock.okJson(ufcFlagsResponseJson)));
 
     // If we get the dummy bandit API key, return bandit-flags-v1.json
     String banditFlagsResponseJson =
-      readConfig(
-        "src/test/resources/shared/ufc/bandit-flags-v1.json");
+        readConfig("src/test/resources/shared/ufc/bandit-flags-v1.json");
     mockServer.stubFor(
-      WireMock.get(WireMock.urlMatching(".*flag-config/v1/config\\?.*apiKey="+DUMMY_BANDIT_API_KEY+".*"))
-        .willReturn(WireMock.okJson(banditFlagsResponseJson)));
+        WireMock.get(
+                WireMock.urlMatching(
+                    ".*flag-config/v1/config\\?.*apiKey=" + DUMMY_BANDIT_API_KEY + ".*"))
+            .willReturn(WireMock.okJson(banditFlagsResponseJson)));
 
     // Return bandit models (no need to switch on API key)
     String banditModelsResponseJson =
@@ -154,7 +154,7 @@ public void testLoggers() {
     actions.put("reebok", rebookAttributes);
 
     BanditResult banditResult =
-      eppoClient.getBanditAction(flagKey, subjectKey, subjectAttributes, actions, "control");
+        eppoClient.getBanditAction(flagKey, subjectKey, subjectAttributes, actions, "control");
 
     // Verify assignment
     assertEquals("banner_bandit", banditResult.getVariation());
@@ -166,7 +166,7 @@ public void testLoggers() {
 
     // Verify bandit logger called
     ArgumentCaptor<BanditAssignment> banditLogCaptor =
-      ArgumentCaptor.forClass(BanditAssignment.class);
+        ArgumentCaptor.forClass(BanditAssignment.class);
     verify(mockBanditLogger, times(1)).logBanditAssignment(banditLogCaptor.capture());
   }
 
@@ -180,33 +180,32 @@ public void getInstanceWhenUninitialized() {
   public void testErrorGracefulModeOn() {
     initBuggyClient();
     EppoClient.getInstance().setIsGracefulFailureMode(true);
-    assertEquals(1.234, EppoClient.getInstance().getDoubleAssignment("numeric_flag", "subject1", 1.234));
+    assertEquals(
+        1.234, EppoClient.getInstance().getDoubleAssignment("numeric_flag", "subject1", 1.234));
   }
 
   @Test
   public void testErrorGracefulModeOff() {
     initBuggyClient();
     EppoClient.getInstance().setIsGracefulFailureMode(false);
-    assertThrows(Exception.class, () -> EppoClient.getInstance().getDoubleAssignment("numeric_flag", "subject1", 1.234));
+    assertThrows(
+        Exception.class,
+        () -> EppoClient.getInstance().getDoubleAssignment("numeric_flag", "subject1", 1.234));
   }
 
   @Test
   public void testReinitializeWithoutForcing() {
     EppoClient firstInstance = initClient(DUMMY_FLAG_API_KEY);
-    EppoClient secondInstance = new EppoClient.Builder()
-      .apiKey(DUMMY_FLAG_API_KEY)
-      .buildAndInit();
+    EppoClient secondInstance = new EppoClient.Builder().apiKey(DUMMY_FLAG_API_KEY).buildAndInit();
 
     assertSame(firstInstance, secondInstance);
   }
 
   @Test
   public void testReinitializeWitForcing() {
     EppoClient firstInstance = initClient(DUMMY_FLAG_API_KEY);
-    EppoClient secondInstance = new EppoClient.Builder()
-      .apiKey(DUMMY_FLAG_API_KEY)
-      .forceReinitialize(true)
-      .buildAndInit();
+    EppoClient secondInstance =
+        new EppoClient.Builder().apiKey(DUMMY_FLAG_API_KEY).forceReinitialize(true).buildAndInit();
 
     assertNotSame(firstInstance, secondInstance);
   }
@@ -218,11 +217,12 @@ public void testPolling() {
     TestUtils.setBaseClientHttpClientOverrideField(httpClientSpy);
 
     new EppoClient.Builder()
-      .apiKey(DUMMY_FLAG_API_KEY)
-      .pollingIntervalMs(20)
-      .forceReinitialize(true)
-      .buildAndInit();
+        .apiKey(DUMMY_FLAG_API_KEY)
+        .pollingIntervalMs(20)
+        .forceReinitialize(true)
+        .buildAndInit();
 
+    // Method will be called immediately on init
     verify(httpClientSpy, times(1)).get(anyString());
 
     // Sleep for 25 ms to allow another polling cycle to complete
@@ -252,13 +252,13 @@ private EppoClient initClient(String apiKey) {
     mockBanditLogger = mock(BanditLogger.class);
 
     return new EppoClient.Builder()
-      .apiKey(apiKey)
-      .host(TEST_HOST)
-      .assignmentLogger(mockAssignmentLogger)
-      .banditLogger(mockBanditLogger)
-      .isGracefulMode(false)
-      .forceReinitialize(true) // Useful for tests
-      .buildAndInit();
+        .apiKey(apiKey)
+        .host(TEST_HOST)
+        .assignmentLogger(mockAssignmentLogger)
+        .banditLogger(mockBanditLogger)
+        .isGracefulMode(false)
+        .forceReinitialize(true) // Useful for tests
+        .buildAndInit();
   }
 
   private void uninitClient() {