don't block on init

Author: typotter

src/main/java/cloud/eppo/EppoClient.java

@@ -197,17 +197,10 @@ public EppoClient buildAndInit() {
               pollingIntervalMs,
               pollingIntervalMs / DEFAULT_JITTER_INTERVAL_RATIO);
 
-      fetchConfigurationsTask.scheduleNext();
-
-      // Kick off the first fetch, respecting graceful mode.
-      try {
-        instance.loadConfiguration();
-      } catch (RuntimeException e) {
-        log.error("Encountered Exception while loading configuration", e);
-        if (!isGracefulMode) {
-          throw e;
-        }
-      }
+      // Kick off the first fetch
+      // Graceful mode is implicit here because `FetchConfigurationsTask` catches and logs errors
+      // without rethrowing.
+      fetchConfigurationsTask.run();
 
       return instance;
     }

src/main/java/cloud/eppo/FetchConfigurationsTask.java

@@ -28,10 +28,6 @@ public void run() {
     } catch (Exception e) {
       log.error("[Eppo SDK] Error fetching experiment configuration", e);
     }
-    scheduleNext();
-  }
-
-  public void scheduleNext() {
 
     long delay = this.intervalInMillis - (long) (Math.random() * this.jitterInMillis);
     FetchConfigurationsTask nextTask =

src/test/java/cloud/eppo/EppoClientTest.java

@@ -239,14 +239,8 @@ public void testPolling() {
     verify(httpClientSpy, times(2)).get(anyString());
   }
 
-  @Test
-  public void testGracefulInitializationFailure() {
-    // Set up bad HTTP response
-    mockHttpError();
-
-    // Initialize and no exception should be thrown.
-    assertDoesNotThrow(() -> initFailingGracefulClient(true));
-  }
+  // NOTE: Graceful mode during init is intrinsically true since the call is non-blocking and
+  // exceptions are caught without rethrowing in `FetchConfigurationsTask`
 
   @Test
   public void testClientMakesDefaultAssignmentsAfterFailingToInitialize() {
@@ -256,40 +250,13 @@ public void testClientMakesDefaultAssignmentsAfterFailingToInitialize() {
     // Initialize and no exception should be thrown.
     try {
       EppoClient eppoClient = initFailingGracefulClient(true);
+      Thread.sleep(25); // Sleep to allow the async config fetch call to happen (and fail)
       assertEquals("default", eppoClient.getStringAssignment("experiment1", "subject1", "default"));
     } catch (Exception e) {
       fail("Unexpected exception: " + e);
     }
   }
 
-  @Test
-  public void testClientMakesDefaultAssignmentsAfterFailingToInitializeNonGracefulMode() {
-    // Set up bad HTTP response
-    mockHttpError();
-
-    // Initialize and the exception should be thrown.
-    try {
-      initFailingGracefulClient(false);
-      fail("Exception should have been thrown");
-    } catch (RuntimeException e) {
-      // Expected
-      assertEquals("Intentional Error", e.getMessage());
-    } finally {
-      assertEquals(
-          "default",
-          EppoClient.getInstance().getStringAssignment("experiment1", "subject1", "default"));
-    }
-  }
-
-  @Test
-  public void testNonGracefulInitializationFailure() {
-    // Set up bad HTTP response
-    mockHttpError();
-
-    // Initialize and assert exception thrown
-    assertThrows(Exception.class, () -> initFailingGracefulClient(false));
-  }
-
   public static void mockHttpError() {
     // Create a mock instance of EppoHttpClient
     EppoHttpClient mockHttpClient = mock(EppoHttpClient.class);