Skip to content

Commit c9e4d75

Browse files
committed
remove host since we're major bumping
1 parent 535fba5 commit c9e4d75

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

src/main/java/cloud/eppo/EppoClient.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ private EppoClient(
3939
String apiKey,
4040
String sdkName,
4141
String sdkVersion,
42-
@Nullable @Deprecated String host,
4342
@Nullable String baseUrl,
4443
@Nullable AssignmentLogger assignmentLogger,
4544
@Nullable BanditLogger banditLogger,
@@ -50,7 +49,7 @@ private EppoClient(
5049
apiKey,
5150
sdkName,
5251
sdkVersion,
53-
host,
52+
null,
5453
baseUrl,
5554
assignmentLogger,
5655
banditLogger,
@@ -78,7 +77,6 @@ public static class Builder {
7877
private boolean isGracefulMode = DEFAULT_IS_GRACEFUL_MODE;
7978
private boolean forceReinitialize = DEFAULT_FORCE_REINITIALIZE;
8079
private long pollingIntervalMs = DEFAULT_POLLING_INTERVAL_MS;
81-
private String host = null; // TODO remove with next major version bump.
8280
private String apiBaseUrl = null;
8381

8482
// Assignment and bandit caching on by default. To disable, call
@@ -140,16 +138,6 @@ public Builder pollingIntervalMs(long pollingIntervalMs) {
140138
return this;
141139
}
142140

143-
/**
144-
* Overrides the host from where it fetches configurations. This typically should not be
145-
* explicitly set so that the default of the Fastly CDN is used. @Deprecated - use `apiBaseUrl`
146-
* instead
147-
*/
148-
public Builder host(String host) {
149-
this.host = host;
150-
return this;
151-
}
152-
153141
/**
154142
* Overrides the base URL from where the SDK fetches configurations. This typically should not
155143
* be explicitly set so that the default API URL is used.
@@ -190,7 +178,6 @@ public EppoClient buildAndInit() {
190178
apiKey,
191179
sdkName,
192180
sdkVersion,
193-
host, // TODO remove with next major version bump.
194181
apiBaseUrl,
195182
assignmentLogger,
196183
banditLogger,

src/test/java/cloud/eppo/EppoClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ private EppoClient initClient(String apiKey) {
287287

288288
return new EppoClient.Builder()
289289
.apiKey(apiKey)
290-
.host(TEST_HOST)
290+
.apiBaseUrl(Constants.appendApiPathToHost(TEST_HOST))
291291
.assignmentLogger(mockAssignmentLogger)
292292
.banditLogger(mockBanditLogger)
293293
.isGracefulMode(false)
@@ -301,7 +301,7 @@ private EppoClient initFailingGracefulClient(boolean isGracefulMode) {
301301

302302
return new EppoClient.Builder()
303303
.apiKey(DUMMY_FLAG_API_KEY)
304-
.host("blag")
304+
.apiBaseUrl("blag")
305305
.assignmentLogger(mockAssignmentLogger)
306306
.banditLogger(mockBanditLogger)
307307
.isGracefulMode(isGracefulMode)

0 commit comments

Comments
 (0)