vibe: lint fixes (#247)

typotter · web-flow · commit 588f3f4a3cf3 · 2025-08-21T11:00:52.000-06:00
* vibe: lint fixes

* update docs
diff --git a/docs/index.md b/docs/index.md
@@ -27,3 +27,4 @@ Description
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.buildstoragekeysuffix.md b/docs/js-client-sdk.buildstoragekeysuffix.md
@@ -47,6 +47,7 @@ The API key to build the suffix from
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 string
diff --git a/docs/js-client-sdk.chromestorageengine._constructor_.md b/docs/js-client-sdk.chromestorageengine._constructor_.md
@@ -59,3 +59,4 @@ string
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.chromestorageengine.md b/docs/js-client-sdk.chromestorageengine.md
@@ -143,3 +143,4 @@ Description
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.eppojsclient.getbanditaction.md b/docs/js-client-sdk.eppojsclient.getbanditaction.md
@@ -99,6 +99,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 Omit&lt;IAssignmentDetails&lt;string&gt;, 'evaluationDetails'&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getbanditactiondetails.md b/docs/js-client-sdk.eppojsclient.getbanditactiondetails.md
@@ -99,6 +99,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;string&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getboolassignment.md b/docs/js-client-sdk.eppojsclient.getboolassignment.md
@@ -90,6 +90,7 @@ boolean
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 boolean
diff --git a/docs/js-client-sdk.eppojsclient.getbooleanassignment.md b/docs/js-client-sdk.eppojsclient.getbooleanassignment.md
@@ -85,6 +85,7 @@ boolean
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 boolean
diff --git a/docs/js-client-sdk.eppojsclient.getbooleanassignmentdetails.md b/docs/js-client-sdk.eppojsclient.getbooleanassignmentdetails.md
@@ -85,6 +85,7 @@ boolean
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;boolean&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getexperimentcontainerentry.md b/docs/js-client-sdk.eppojsclient.getexperimentcontainerentry.md
@@ -71,6 +71,7 @@ Record&lt;string, AttributeType&gt;
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 T
diff --git a/docs/js-client-sdk.eppojsclient.getintegerassignment.md b/docs/js-client-sdk.eppojsclient.getintegerassignment.md
@@ -85,6 +85,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 number
diff --git a/docs/js-client-sdk.eppojsclient.getintegerassignmentdetails.md b/docs/js-client-sdk.eppojsclient.getintegerassignmentdetails.md
@@ -85,6 +85,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;number&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getjsonassignment.md b/docs/js-client-sdk.eppojsclient.getjsonassignment.md
@@ -85,6 +85,7 @@ object
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 object
diff --git a/docs/js-client-sdk.eppojsclient.getjsonassignmentdetails.md b/docs/js-client-sdk.eppojsclient.getjsonassignmentdetails.md
@@ -85,6 +85,7 @@ object
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;object&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getnumericassignment.md b/docs/js-client-sdk.eppojsclient.getnumericassignment.md
@@ -85,6 +85,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 number
diff --git a/docs/js-client-sdk.eppojsclient.getnumericassignmentdetails.md b/docs/js-client-sdk.eppojsclient.getnumericassignmentdetails.md
@@ -85,6 +85,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;number&gt;
diff --git a/docs/js-client-sdk.eppojsclient.getstringassignment.md b/docs/js-client-sdk.eppojsclient.getstringassignment.md
@@ -85,6 +85,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 string
diff --git a/docs/js-client-sdk.eppojsclient.getstringassignmentdetails.md b/docs/js-client-sdk.eppojsclient.getstringassignmentdetails.md
@@ -85,6 +85,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 IAssignmentDetails&lt;string&gt;
diff --git a/docs/js-client-sdk.eppojsclient.md b/docs/js-client-sdk.eppojsclient.md
@@ -263,3 +263,4 @@ Description
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getbanditaction.md b/docs/js-client-sdk.eppoprecomputedjsclient.getbanditaction.md
@@ -57,6 +57,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 Omit&lt;IAssignmentDetails&lt;string&gt;, 'evaluationDetails'&gt;
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getbooleanassignment.md b/docs/js-client-sdk.eppoprecomputedjsclient.getbooleanassignment.md
@@ -57,6 +57,7 @@ boolean
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 boolean
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getintegerassignment.md b/docs/js-client-sdk.eppoprecomputedjsclient.getintegerassignment.md
@@ -57,6 +57,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 number
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getjsonassignment.md b/docs/js-client-sdk.eppoprecomputedjsclient.getjsonassignment.md
@@ -57,6 +57,7 @@ object
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 object
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getnumericassignment.md b/docs/js-client-sdk.eppoprecomputedjsclient.getnumericassignment.md
@@ -57,6 +57,7 @@ number
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 number
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.getstringassignment.md b/docs/js-client-sdk.eppoprecomputedjsclient.getstringassignment.md
@@ -57,6 +57,7 @@ string
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 string
diff --git a/docs/js-client-sdk.eppoprecomputedjsclient.md b/docs/js-client-sdk.eppoprecomputedjsclient.md
@@ -167,3 +167,4 @@ Description
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.getconfigurl.md b/docs/js-client-sdk.getconfigurl.md
@@ -61,6 +61,7 @@ _(Optional)_
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 string
diff --git a/docs/js-client-sdk.iclientconfig.md b/docs/js-client-sdk.iclientconfig.md
@@ -208,3 +208,4 @@ _(Optional)_ Whether initialization will be considered successfully complete if
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.iclientconfigsync.md b/docs/js-client-sdk.iclientconfigsync.md
@@ -205,3 +205,4 @@ _(Optional)_
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.init.md b/docs/js-client-sdk.init.md
@@ -47,6 +47,7 @@ client configuration
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 Promise&lt;[EppoJSClient](./js-client-sdk.eppojsclient.md)<!-- -->&gt;
diff --git a/docs/js-client-sdk.iprecomputedclientconfig.md b/docs/js-client-sdk.iprecomputedclientconfig.md
@@ -92,3 +92,4 @@ IPrecompute
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.iprecomputedclientconfigsync.md b/docs/js-client-sdk.iprecomputedclientconfigsync.md
@@ -150,3 +150,4 @@ _(Optional)_
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.md b/docs/js-client-sdk.md
@@ -227,3 +227,4 @@ This interface is used for cases where precomputed assignments are available fro
 
 </td></tr>
 </tbody></table>
+
diff --git a/docs/js-client-sdk.offlineinit.md b/docs/js-client-sdk.offlineinit.md
@@ -51,6 +51,7 @@ client configuration
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 EppoClient
diff --git a/docs/js-client-sdk.offlineprecomputedinit.md b/docs/js-client-sdk.offlineprecomputedinit.md
@@ -51,6 +51,7 @@ precomputed client configuration
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 EppoPrecomputedClient
diff --git a/docs/js-client-sdk.precomputedinit.md b/docs/js-client-sdk.precomputedinit.md
@@ -47,6 +47,7 @@ client configuration
 
 </td></tr>
 </tbody></table>
+
 **Returns:**
 
 Promise&lt;EppoPrecomputedClient&gt;
diff --git a/src/local-storage-engine.spec.ts b/src/local-storage-engine.spec.ts
@@ -139,6 +139,7 @@ describe('LocalStorageEngine', () => {
         .mockImplementationOnce(() => {
           throw quotaError;
         })
+
         .mockImplementationOnce(jest.fn()); // Success on retry
 
       await engine.setContentsJsonString('test-config');
diff --git a/src/local-storage.store.spec.ts b/src/local-storage.store.spec.ts
@@ -3,7 +3,11 @@
  */
 
 import { LocalStorageEngine } from './local-storage-engine';
-import { StringValuedAsyncStore, StorageFullUnableToWrite, LocalStorageUnknownFailure } from './string-valued.store';
+import {
+  StringValuedAsyncStore,
+  StorageFullUnableToWrite,
+  LocalStorageUnknownFailure,
+} from './string-valued.store';
 
 describe('LocalStorageStore', () => {
   // Note: window.localStorage is mocked for the node environment via the jsdom jest environment
@@ -101,55 +105,66 @@ describe('LocalStorageStore', () => {
   });
 
   describe('StorageFullUnableToWrite exception handling', () => {
-    let mockLocalStorage: Storage;
+    // We need to mock localStorage with a controllable length property for testing
+    // The Storage interface has a read-only 'length' property, so we extend it with
+    // a private '_length' property that we can modify in tests
+    let mockLocalStorage: Storage & { _length: number };
     let localStorageEngineWithMock: LocalStorageEngine;
 
     beforeEach(() => {
       mockLocalStorage = {
+        // Getter that returns the mockable length value
+        // This allows us to control the length for testing different scenarios
+        get length() {
+          return this._length || 0;
+        },
+        // Private property that we can modify to simulate different storage states
+        _length: 0,
         getItem: jest.fn(),
         setItem: jest.fn(),
         removeItem: jest.fn(),
         clear: jest.fn(),
-        length: 0,
         key: jest.fn(),
-      };
+      } as Storage & { _length: number };
       localStorageEngineWithMock = new LocalStorageEngine(mockLocalStorage, 'test');
     });
 
     it('should throw StorageFullUnableToWrite when setContentsJsonString fails after clear and retry', async () => {
       const quotaError = new DOMException('QuotaExceededError', 'QuotaExceededError');
       Object.defineProperty(quotaError, 'code', { value: DOMException.QUOTA_EXCEEDED_ERR });
-      
+
       (mockLocalStorage.setItem as jest.Mock).mockImplementation(() => {
         throw quotaError;
       });
       (mockLocalStorage.key as jest.Mock).mockReturnValue(null);
-      (mockLocalStorage.length as any) = 0;
+      // Simulate empty storage by setting length to 0
+      mockLocalStorage._length = 0;
 
-      await expect(
-        localStorageEngineWithMock.setContentsJsonString('test-config')
-      ).rejects.toThrow(StorageFullUnableToWrite);
+      await expect(localStorageEngineWithMock.setContentsJsonString('test-config')).rejects.toThrow(
+        StorageFullUnableToWrite,
+      );
     });
 
     it('should throw StorageFullUnableToWrite when setMetaJsonString fails after clear and retry', async () => {
       const quotaError = new DOMException('QuotaExceededError', 'QuotaExceededError');
       Object.defineProperty(quotaError, 'code', { value: DOMException.QUOTA_EXCEEDED_ERR });
-      
+
       (mockLocalStorage.setItem as jest.Mock).mockImplementation(() => {
         throw quotaError;
       });
       (mockLocalStorage.key as jest.Mock).mockReturnValue(null);
-      (mockLocalStorage.length as any) = 0;
+      // Simulate empty storage by setting length to 0
+      mockLocalStorage._length = 0;
 
-      await expect(
-        localStorageEngineWithMock.setMetaJsonString('test-meta')
-      ).rejects.toThrow(StorageFullUnableToWrite);
+      await expect(localStorageEngineWithMock.setMetaJsonString('test-meta')).rejects.toThrow(
+        StorageFullUnableToWrite,
+      );
     });
 
     it('should succeed after clearing when retry works', async () => {
       const quotaError = new DOMException('QuotaExceededError', 'QuotaExceededError');
       Object.defineProperty(quotaError, 'code', { value: DOMException.QUOTA_EXCEEDED_ERR });
-      
+
       let callCount = 0;
       (mockLocalStorage.setItem as jest.Mock).mockImplementation(() => {
         callCount++;
@@ -159,12 +174,13 @@ describe('LocalStorageStore', () => {
         // Second call succeeds
       });
       (mockLocalStorage.key as jest.Mock).mockReturnValue('eppo-configuration-old');
-      (mockLocalStorage.length as any) = 1;
+      // Simulate storage with one item by setting length to 1
+      mockLocalStorage._length = 1;
 
       await expect(
-        localStorageEngineWithMock.setContentsJsonString('test-config')
+        localStorageEngineWithMock.setContentsJsonString('test-config'),
       ).resolves.not.toThrow();
-      
+
       expect(mockLocalStorage.removeItem).toHaveBeenCalledWith('eppo-configuration-old');
       expect(mockLocalStorage.setItem).toHaveBeenCalledTimes(2);
     });
@@ -175,7 +191,9 @@ describe('LocalStorageStore', () => {
         throw otherError;
       });
 
-      const error = await localStorageEngineWithMock.setContentsJsonString('test-config').catch(e => e);
+      const error = await localStorageEngineWithMock
+        .setContentsJsonString('test-config')
+        .catch((e) => e);
       expect(error).toBeInstanceOf(LocalStorageUnknownFailure);
       expect(error.originalError).toBe(otherError);
       expect(error.message).toContain('Some other error');

Original file line number	Diff line number	Diff line change
`@@ -27,3 +27,4 @@ Description`
`27`	`27`
`28`	`28`	`</td></tr>`
`29`	`29`	`</tbody></table>`
	`30`	`+`
Original file line number	Diff line number	Diff line change
`@@ -59,3 +59,4 @@ string`
`59`	`59`
`60`	`60`	`</td></tr>`
`61`	`61`	`</tbody></table>`
	`62`	`+`
Original file line number	Diff line number	Diff line change
`@@ -143,3 +143,4 @@ Description`
`143`	`143`
`144`	`144`	`</td></tr>`
`145`	`145`	`</tbody></table>`
	`146`	`+`
Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,7 @@ Record<string, AttributeType>`
`71`	`71`
`72`	`72`	`</td></tr>`
`73`	`73`	`</tbody></table>`
	`74`	`+`
`74`	`75`	`Returns:`
`75`	`76`
`76`	`77`	`T`