simplify session storage

Author: ploomiz

src/index.ts

@@ -71,7 +71,7 @@ export async function init(config: IClientConfig): Promise<IEppoClient> {
     configurationRequestor,
     config.subjectAttributes,
   );
-  if (!configurationStore.isSessionStorageInitialized()) {
+  if (!configurationStore.isInitialized()) {
     await configurationRequestor.fetchAndStoreConfigurations();
   }
   return clientInstance;

src/storage.spec.ts

@@ -27,9 +27,9 @@ describe('EppoSessionStorage', () => {
     });
 
     it('returns stored entries', () => {
-      expect(storage.isSessionStorageInitialized()).toEqual(false);
+      expect(storage.isInitialized()).toEqual(false);
       storage.setEntries({ key1: config1, key2: config2 });
-      expect(storage.isSessionStorageInitialized()).toEqual(true);
+      expect(storage.isInitialized()).toEqual(true);
       expect(storage.get<ITestEntry>('key1')).toEqual(config1);
       expect(storage.get<ITestEntry>('key2')).toEqual(config2);
     });

src/storage.ts

@@ -1,53 +1,36 @@
 const SESSION_STORAGE_INITIALIZED = 'eppo-session-storage-initialized';
 
 export class EppoSessionStorage {
-  // Fallback storage in case the user has disabled session storage in the browser.
-  private fallbackStorage: Record<string, string> = {};
-
   public get<T>(key: string): T {
-    let serializedEntry;
     if (this.hasWindowSessionStorage()) {
-      serializedEntry = window.sessionStorage.getItem(key);
-    } else {
-      serializedEntry = this.fallbackStorage[key];
-    }
-    if (serializedEntry) {
-      return JSON.parse(serializedEntry);
+      const serializedEntry = window.sessionStorage.getItem(key);
+      if (serializedEntry) {
+        return JSON.parse(serializedEntry);
+      }
     }
     return null;
   }
 
+  // Checks whether session storage is enabled in the browser (the user might have disabled it).
   private hasWindowSessionStorage(): boolean {
     try {
       return typeof window !== 'undefined' && !!window.sessionStorage;
     } catch {
-      // Some browsers throw an error if session storage is disabled and you try to access it
+      // Chrome throws an error if session storage is disabled and you try to access it
       return false;
     }
   }
 
-  public isSessionStorageInitialized(): boolean {
+  public isInitialized(): boolean {
     return !!this.get(SESSION_STORAGE_INITIALIZED);
   }
 
   public setEntries<T>(entries: Record<string, T>) {
     if (this.hasWindowSessionStorage()) {
-      this.setEntriesInSessionStorage(entries);
-    } else {
-      this.setEntriesInFallbackStorage(entries);
+      Object.entries(entries).forEach(([key, val]) => {
+        window.sessionStorage.setItem(key, JSON.stringify(val));
+      });
+      window.sessionStorage.setItem(SESSION_STORAGE_INITIALIZED, 'true');
     }
   }
-
-  private setEntriesInSessionStorage<T>(entries: Record<string, T>) {
-    Object.entries(entries).forEach(([key, val]) => {
-      window.sessionStorage.setItem(key, JSON.stringify(val));
-    });
-    window.sessionStorage.setItem(SESSION_STORAGE_INITIALIZED, 'true');
-  }
-
-  private setEntriesInFallbackStorage<T>(entries: Record<string, T>) {
-    Object.entries(entries).forEach(([key, val]) => {
-      this.fallbackStorage[key] = JSON.stringify(val);
-    });
-  }
 }