chore: latest from common, drop isObfuscated calls (#192)

* chore: latest from common dropping isObfuscated calls
* fix tests for api endpoints change
* 3.14.1

Author: typotter

docs/js-client-sdk.getconfigurl.md

@@ -9,7 +9,7 @@ Used to build the URL for fetching the flag configuration.
 **Signature:**
 
 ```typescript
-export declare function getConfigUrl(apiKey: string, baseUrl?: string): URL;
+export declare function getConfigUrl(apiKey: string, baseUrl?: string): string;
 ```
 
 ## Parameters
@@ -63,7 +63,7 @@ _(Optional)_
 </tbody></table>
 **Returns:**
 
-URL
+string
 
 a URL string
 

js-client-sdk.api.md

@@ -121,7 +121,7 @@ export class EppoPrecomputedJSClient extends EppoPrecomputedClient {
 export { Flag }
 
 // @public
-export function getConfigUrl(apiKey: string, baseUrl?: string): URL;
+export function getConfigUrl(apiKey: string, baseUrl?: string): string;
 
 // @public
 export function getInstance(): EppoJSClient;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eppo/js-client-sdk",
-  "version": "3.14.0",
+  "version": "3.14.1",
   "description": "Eppo SDK for client-side JavaScript applications",
   "main": "dist/index.js",
   "files": [
@@ -60,7 +60,7 @@
     "webpack-cli": "^6.0.1"
   },
   "dependencies": {
-    "@eppo/js-client-sdk-common": "4.14.1"
+    "@eppo/js-client-sdk-common": "4.14.4"
   },
   "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

src/index.spec.ts

@@ -393,6 +393,9 @@ describe('sync init', () => {
       },
     });
 
+    expect(Object.keys(client.getFlagConfigurations())).toEqual([
+      '76c488348976aa431acb31f4d752dde8',
+    ]);
     expect(client.getStringAssignment(flagKey, 'subject-10', {}, 'default-value')).toEqual(
       'variant-1',
     );
@@ -1223,20 +1226,20 @@ describe('getConfigUrl function', () => {
 
   it('should return a URL using the default base URL when no base URL is provided', () => {
     const url = getConfigUrl(apiKey);
-    expect(url.toString()).toContain(defaultBaseUrl);
-    expect(url.toString()).not.toContain(customBaseUrl);
-    expect(url.toString()).toContain(`apiKey=${apiKey}`);
-    expect(url.toString()).toContain('sdkName=');
-    expect(url.toString()).toContain('sdkVersion=');
+    expect(url).toContain(defaultBaseUrl);
+    expect(url).not.toContain(customBaseUrl);
+    expect(url).toContain(`apiKey=${apiKey}`);
+    expect(url).toContain('sdkName=');
+    expect(url).toContain('sdkVersion=');
   });
 
   it('should return a URL using the provided base URL', () => {
     const url = getConfigUrl(apiKey, customBaseUrl);
-    expect(url.toString()).toContain(customBaseUrl);
-    expect(url.toString()).not.toContain(defaultBaseUrl);
-    expect(url.toString()).toContain(`apiKey=${apiKey}`);
-    expect(url.toString()).toContain('sdkName=');
-    expect(url.toString()).toContain('sdkVersion=');
+    expect(url).toContain(customBaseUrl);
+    expect(url).not.toContain(defaultBaseUrl);
+    expect(url).toContain(`apiKey=${apiKey}`);
+    expect(url).toContain('sdkName=');
+    expect(url).toContain('sdkVersion=');
   });
 });
 

src/index.ts

@@ -120,7 +120,6 @@ export class EppoJSClient extends EppoClient {
    */
   public static instance = new EppoJSClient({
     flagConfigurationStore,
-    isObfuscated: true,
   });
 
   public static initialized = false;
@@ -313,8 +312,6 @@ export class EppoJSClient extends EppoClient {
       if (config.banditLogger) {
         this.setBanditLogger(config.banditLogger);
       }
-      // Default to obfuscated mode when requesting configuration from the server.
-      this.setIsObfuscated(true);
 
       const storageKeySuffix = buildStorageKeySuffix(apiKey);
 
@@ -340,7 +337,6 @@ export class EppoJSClient extends EppoClient {
       // We do this because we don't store any metadata in the persistent store and can make the assumption that entries
       // in the persistent store are obfuscated since the reason behind obfuscation is to obfuscate any data stored on a
       // user device.
-      this.setIsObfuscated(true); // Use deprecated method to silence warning logs.
       configurationStore.setFormat(FormatEnum.CLIENT);
       this.setFlagConfigurationStore(configurationStore);
 
@@ -531,7 +527,13 @@ export class EppoJSClient extends EppoClient {
       const memoryOnlyConfigurationStore = configurationStorageFactory({
         forceMemoryOnly: true,
       });
+
+      // Allow the caller to override the default obfuscated mode, which is false
+      // since the purpose of this method is to bootstrap the SDK from an external source,
+      // which is likely a server that has not-obfuscated flag values.
+      // This is the equivalent of setIsObfuscated
       memoryOnlyConfigurationStore.setFormat(isObfuscated ? FormatEnum.CLIENT : FormatEnum.SERVER);
+
       memoryOnlyConfigurationStore
         .setEntries(config.flagsConfiguration)
         .catch((err) =>
@@ -555,11 +557,6 @@ export class EppoJSClient extends EppoClient {
         this.unsetOverrideStore();
       }
 
-      // Allow the caller to override the default obfuscated mode, which is false
-      // since the purpose of this method is to bootstrap the SDK from an external source,
-      // which is likely a server that has not-obfuscated flag values.
-      this.setIsObfuscated(isObfuscated);
-
       if (config.assignmentLogger) {
         this.setAssignmentLogger(config.assignmentLogger);
       }
@@ -686,7 +683,7 @@ export function getInstance(): EppoJSClient {
  * @returns a URL string
  * @public
  */
-export function getConfigUrl(apiKey: string, baseUrl?: string): URL {
+export function getConfigUrl(apiKey: string, baseUrl?: string): string {
   const queryParams = { sdkName, sdkVersion, apiKey };
   return new ApiEndpoints({ baseUrl, queryParams }).ufcEndpoint();
 }

yarn.lock

@@ -380,10 +380,10 @@
   resolved "https://registry.yarnpkg.com/@discoveryjs/json-ext/-/json-ext-0.6.3.tgz#f13c7c205915eb91ae54c557f5e92bddd8be0e83"
   integrity sha512-4B4OijXeVNOPZlYA2oEwWOTkzyltLao+xbotHQeqN++Rv27Y6s818+n2Qkp8q+Fxhn0t/5lA5X1Mxktud8eayQ==
 
-"@eppo/[email protected].1":
-  version "4.14.1"
-  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.14.1.tgz#db908420c47a1327921493072892923e58c2039f"
-  integrity sha512-trXgxPgbS+vFkYd0w0Xb2V9NntE2SgLsThhxoDbRENw1ynb8b8b3MDdwFH+5DheVT1ji6mZ+Qrh40uNIxMptYA==
+"@eppo/[email protected].4":
+  version "4.14.4"
+  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.14.4.tgz#fd59daa3b9ae385756476bcc1022a53ffcfd8188"
+  integrity sha512-12JKsYLu+WICH1t9NEgWoxTYc/MyFnZAHhcBJwfcaG0tPIbPfgG9VBT8yTUgBLG8cYZBmDVk7R7SzMGc3vD2eg==
   dependencies:
     buffer "npm:@eppo/[email protected]"
     js-base64 "^3.7.7"