latest with precomputed

Author: typotter

package.json

@@ -59,7 +59,7 @@
     "webpack-cli": "^4.10.0"
   },
   "dependencies": {
-    "@eppo/js-client-sdk-common": "^4.6.3"
+    "@eppo/js-client-sdk-common": "^4.7.0-alpha.1"
   },
   "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

src/i-client-config.ts

@@ -1,4 +1,10 @@
-import { AttributeType, Flag, IAssignmentLogger, IAsyncStore } from '@eppo/js-client-sdk-common';
+import {
+  AttributeType,
+  ContextAttributes,
+  Flag,
+  IAssignmentLogger,
+  IAsyncStore,
+} from '@eppo/js-client-sdk-common';
 import { EventDispatcherConfig } from '@eppo/js-client-sdk-common/src/events/default-event-dispatcher';
 
 import { ServingStoreUpdateStrategy } from './isolatable-hybrid.store';
@@ -76,7 +82,7 @@ export interface IPrecomputedClientConfig extends IBaseRequestConfig {
   /**
    * Subject attributes to use for precomputed flag assignments.
    */
-  subjectAttributes?: Record<string, AttributeType>;
+  subjectAttributes?: ContextAttributes;
 }
 
 /**

src/index.spec.ts

@@ -1063,6 +1063,11 @@ describe('getConfigUrl function', () => {
 describe('EppoPrecomputedJSClient E2E test', () => {
   let globalClient: EppoPrecomputedJSClient;
   let mockLogger: IAssignmentLogger;
+  const stringFlagMD5 = '7724c9cf3eeb7e9478d4c5d45d523db0';
+  const booleanFlagMD5 = 'da342f2d2df9aa65fd422191c581d4dc';
+  const numericFlagMD5 = 'ea3957393f8c54d09bb0800186480bae';
+  const jsonFlagMD5 = '801c055015c6cf6710d486f099000fea';
+  const integerFlagMD5 = 'eb4caea3db4e58836bda9830ee098291';
 
   beforeAll(async () => {
     global.fetch = jest.fn(() => {
@@ -1077,43 +1082,44 @@ describe('EppoPrecomputedJSClient E2E test', () => {
               name: 'Test',
             },
             flags: {
-              'string-flag': {
-                allocationKey: 'allocation-123',
-                variationKey: 'variation-123',
+              [stringFlagMD5]: {
+                flagKey: stringFlagMD5,
+                allocationKey: base64Encode('allocation-123'),
+                variationKey: base64Encode('variation-123'),
                 variationType: 'STRING',
-                variationValue: 'red',
+                variationValue: base64Encode('red'),
                 extraLogging: {},
                 doLog: true,
               },
-              'boolean-flag': {
-                allocationKey: 'allocation-124',
-                variationKey: 'variation-124',
+              [booleanFlagMD5]: {
+                allocationKey: base64Encode('allocation-124'),
+                variationKey: base64Encode('variation-124'),
                 variationType: 'BOOLEAN',
-                variationValue: true,
+                variationValue: base64Encode('true'),
                 extraLogging: {},
                 doLog: true,
               },
-              'numeric-flag': {
-                allocationKey: 'allocation-126',
-                variationKey: 'variation-126',
+              [numericFlagMD5]: {
+                allocationKey: base64Encode('allocation-126'),
+                variationKey: base64Encode('variation-126'),
                 variationType: 'NUMERIC',
-                variationValue: 3.14,
+                variationValue: base64Encode('3.14'),
                 extraLogging: {},
                 doLog: true,
               },
-              'integer-flag': {
-                allocationKey: 'allocation-125',
-                variationKey: 'variation-125',
+              [integerFlagMD5]: {
+                allocationKey: base64Encode('allocation-125'),
+                variationKey: base64Encode('variation-125'),
                 variationType: 'INTEGER',
-                variationValue: 42,
+                variationValue: base64Encode('42'),
                 extraLogging: {},
                 doLog: true,
               },
-              'json-flag': {
-                allocationKey: 'allocation-127',
-                variationKey: 'variation-127',
+              [jsonFlagMD5]: {
+                allocationKey: base64Encode('allocation-127'),
+                variationKey: base64Encode('variation-127'),
                 variationType: 'JSON',
-                variationValue: '{"key": "value", "number": 123}',
+                variationValue: base64Encode('{"key": "value", "number": 123}'),
                 extraLogging: {},
                 doLog: true,
               },
@@ -1129,7 +1135,7 @@ describe('EppoPrecomputedJSClient E2E test', () => {
       baseUrl: 'http://127.0.0.1:4000',
       assignmentLogger: mockLogger,
       subjectKey: 'test-subject',
-      subjectAttributes: { attr1: 'value1' },
+      subjectAttributes: { categoricalAttributes: { attr1: 'value1' }, numericAttributes: {} },
     });
   });
 
@@ -1205,7 +1211,7 @@ describe('EppoClient config', () => {
     const retryManager = eventDispatcher['retryManager'];
     const batchProcessor = eventDispatcher['batchProcessor'];
     expect(eventDispatcher['deliveryIntervalMs']).toEqual(1);
-    expect(batchProcessor['batchSize']).toEqual(5);
+    expect(batchProcessor['batchSize']).toEqual(100);
     expect(retryManager['config']['retryIntervalMs']).toEqual(2);
     expect(retryManager['config']['maxRetryDelayMs']).toEqual(3);
     expect(retryManager['config']['maxRetries']).toEqual(4);

src/index.ts

@@ -511,9 +511,9 @@ export function getConfigUrl(apiKey: string, baseUrl?: string): URL {
  */
 export class EppoPrecomputedJSClient extends EppoPrecomputedClient {
   // Use an empty memory-only configuration store
-  public static instance: EppoPrecomputedJSClient = new EppoPrecomputedJSClient(
-    memoryOnlyPrecomputedFlagsStore,
-  );
+  public static instance: EppoPrecomputedJSClient = new EppoPrecomputedJSClient({
+    precomputedFlagStore: memoryOnlyPrecomputedFlagsStore,
+  });
   public static initialized = false;
 
   public getStringAssignment(flagKey: string, defaultValue: string): string {
@@ -564,7 +564,6 @@ export async function precomputedInit(
   const {
     apiKey,
     subjectKey,
-    subjectAttributes = {},
     baseUrl,
     requestTimeoutMs,
     numInitialRequestRetries,
@@ -575,6 +574,11 @@ export async function precomputedInit(
     skipInitialRequest = false,
   } = config;
 
+  const subjectAttributes = config.subjectAttributes ?? {
+    categoricalAttributes: {},
+    numericAttributes: {},
+  };
+
   // Set up assignment logger and cache
   instance.setAssignmentLogger(config.assignmentLogger);
 

yarn.lock

@@ -380,10 +380,10 @@
   resolved "https://registry.yarnpkg.com/@discoveryjs/json-ext/-/json-ext-0.5.7.tgz#1d572bfbbe14b7704e0ba0f39b74815b84870d70"
   integrity sha512-dBVuXR082gk3jsFp7Rd/JI4kytwGHecnCoTtXFb7DB6CNHp4rg5k1bhg0nWdLGLnOV71lmDzGQaLMy8iPLY0pw==
 
-"@eppo/js-client-sdk-common@^4.6.3":
-  version "4.6.3"
-  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.6.3.tgz#89267a1c247bc04725b7701cdfb573613c133ddc"
-  integrity sha512-e2nSvzONjqUiAYUjBMIIk1jWuKPOmBl5AlbiNjsoJAd6dZKN1RWpTmy83hNk6ff/syjAEWTcplls2cU37VbyiQ==
+"@eppo/js-client-sdk-common@^4.7.0-alpha.1":
+  version "4.7.0-alpha.1"
+  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.7.0-alpha.1.tgz#ff40526fb9f76ddbcff1264bbb26d8be38b3e25c"
+  integrity sha512-36DF7TVtPkn7JcLrV5YBChp/9Wv0+0bKC32SWrs1ag5/TTyF4cgZYzf1TIsX9ykHvIQGHNPW4Kd3S+TRRVOZ0w==
   dependencies:
     buffer "npm:@eppo/[email protected]"
     js-base64 "^3.7.7"