Bump common version to allow handling of special characters (#135)

* bump common version

* linter fixes

* update test to have valid batch size

* remove now unused import

* feedback from PR

Author: aarsilv

package.json

@@ -59,7 +59,7 @@
     "webpack-cli": "^6.0.1"
   },
   "dependencies": {
-    "@eppo/js-client-sdk-common": "^4.6.3"
+    "@eppo/js-client-sdk-common": "^4.7.1"
   },
   "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

src/events/local-storage-backed-named-event-queue.ts

@@ -47,7 +47,10 @@ export default class LocalStorageBackedNamedEventQueue<T> implements NamedEventQ
     if (this.eventKeys.length === 0) {
       return undefined;
     }
-    const eventKey = this.eventKeys.shift()!;
+    const eventKey = this.eventKeys.shift();
+    if (!eventKey) {
+      throw new Error('Unexpected undefined event key');
+    }
     const eventData = localStorage.getItem(eventKey);
     if (eventData) {
       localStorage.removeItem(eventKey);

src/i-client-config.ts

@@ -1,5 +1,4 @@
 import { AttributeType, Flag, IAssignmentLogger, IAsyncStore } from '@eppo/js-client-sdk-common';
-import { EventDispatcherConfig } from '@eppo/js-client-sdk-common/src/events/default-event-dispatcher';
 
 import { ServingStoreUpdateStrategy } from './isolatable-hybrid.store';
 

src/index.spec.ts

@@ -29,7 +29,6 @@ import { IClientConfig } from './i-client-config';
 import { ServingStoreUpdateStrategy } from './isolatable-hybrid.store';
 
 import {
-  EppoJSClient,
   EppoPrecomputedJSClient,
   getConfigUrl,
   getInstance,
@@ -1188,24 +1187,24 @@ describe('EppoClient config', () => {
         json: () => Promise.resolve({}),
       });
     }) as jest.Mock;
-    EppoJSClient.initialized = false;
     const client = await init({
+      forceReinitialize: true,
       apiKey: 'zCsQuoHJxVPp895.ZWg9MTIzNDU2LmUudGVzdGluZy5lcHBvLmNsb3Vk',
       assignmentLogger: td.object<IAssignmentLogger>(),
       eventIngestionConfig: {
         deliveryIntervalMs: 1,
         retryIntervalMs: 2,
         maxRetryDelayMs: 3,
         maxRetries: 4,
-        batchSize: 5,
+        batchSize: 500,
       },
     });
     // hack to read the private class members config
     const eventDispatcher = client['eventDispatcher'];
     const retryManager = eventDispatcher['retryManager'];
     const batchProcessor = eventDispatcher['batchProcessor'];
     expect(eventDispatcher['deliveryIntervalMs']).toEqual(1);
-    expect(batchProcessor['batchSize']).toEqual(5);
+    expect(batchProcessor['batchSize']).toEqual(500);
     expect(retryManager['config']['retryIntervalMs']).toEqual(2);
     expect(retryManager['config']['maxRetryDelayMs']).toEqual(3);
     expect(retryManager['config']['maxRetries']).toEqual(4);

src/index.ts

@@ -465,8 +465,8 @@ export async function init(config: IClientConfig): Promise<EppoClient> {
       // both failed, make the "fatal" error the fetch one
       initializationError = initFromFetchError;
     }
-  } catch (error: any) {
-    initializationError = error;
+  } catch (error: unknown) {
+    initializationError = error instanceof Error ? error : new Error(String(error));
   }
 
   if (initializationError) {

yarn.lock

@@ -380,10 +380,10 @@
   resolved "https://registry.yarnpkg.com/@discoveryjs/json-ext/-/json-ext-0.6.3.tgz#f13c7c205915eb91ae54c557f5e92bddd8be0e83"
   integrity sha512-4B4OijXeVNOPZlYA2oEwWOTkzyltLao+xbotHQeqN++Rv27Y6s818+n2Qkp8q+Fxhn0t/5lA5X1Mxktud8eayQ==
 
-"@eppo/js-client-sdk-common@^4.6.3":
-  version "4.6.3"
-  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.6.3.tgz#89267a1c247bc04725b7701cdfb573613c133ddc"
-  integrity sha512-e2nSvzONjqUiAYUjBMIIk1jWuKPOmBl5AlbiNjsoJAd6dZKN1RWpTmy83hNk6ff/syjAEWTcplls2cU37VbyiQ==
+"@eppo/js-client-sdk-common@^4.7.1":
+  version "4.7.1"
+  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.7.1.tgz#8a0776055604af65d0e0f8410d4756aa3117992f"
+  integrity sha512-8+5WbFN1EvsS5Ba/qakjDGEhp9loTxSvVHeWaQXKKLXxV+5AhFNOl+d8jSwOkLnP+Qr5D9w1eO7lfzuNDkUcWw==
   dependencies:
     buffer "npm:@eppo/[email protected]"
     js-base64 "^3.7.7"