fix: don't fallback to default value in test harness (#165)

* chore: use non deprecated getBoolean instead of getBool
* fix: don't fallback to testcase default value; getAssignment can not return null.

Author: typotter

src/index.spec.ts

@@ -358,7 +358,7 @@ describe('EppoJSClient E2E test', () => {
         const client = getInstance();
 
         const typeAssignmentFunctions = {
-          [VariationType.BOOLEAN]: client.getBoolAssignment.bind(client),
+          [VariationType.BOOLEAN]: client.getBooleanAssignment.bind(client),
           [VariationType.NUMERIC]: client.getNumericAssignment.bind(client),
           [VariationType.INTEGER]: client.getIntegerAssignment.bind(client),
           [VariationType.STRING]: client.getStringAssignment.bind(client),

test/testHelpers.ts

@@ -90,14 +90,13 @@ export function getTestAssignments(
     assignment: string | boolean | number | object;
   }[] = [];
   for (const subject of testCase.subjects) {
-    const assignment =
-      assignmentFn(
-        testCase.flag,
-        subject.subjectKey,
-        subject.subjectAttributes,
-        testCase.defaultValue,
-        obfuscated,
-      ) || testCase.defaultValue; // Fallback to defaultValue if null
+    const assignment = assignmentFn(
+      testCase.flag,
+      subject.subjectKey,
+      subject.subjectAttributes,
+      testCase.defaultValue,
+      obfuscated,
+    );
     assignments.push({ subject: subject, assignment: assignment });
   }
   return assignments;