fix: getprecomputedinstance should always return an instance (#151)

* Initialize with an empty client

* Add a test

* Adjust check for singleton was initialized

* Check for instance is no longer necessary because it is always defined

Author: sameerank

src/index.spec.ts

@@ -36,6 +36,7 @@ import {
   EppoPrecomputedJSClient,
   getConfigUrl,
   getInstance,
+  getPrecomputedInstance,
   IAssignmentLogger,
   init,
   offlineInit,
@@ -1278,6 +1279,19 @@ describe('offlinePrecomputedInit', () => {
     });
   });
 
+  describe('getPrecomputedInstance', () => {
+    it('returns an instance that safely returns defaults without logging', () => {
+      const mockLogger = td.object<IAssignmentLogger>();
+      const instance = getPrecomputedInstance();
+      instance.setAssignmentLogger(mockLogger);
+
+      const result = instance.getStringAssignment('any-flag', 'default-value');
+
+      expect(result).toBe('default-value');
+      td.verify(mockLogger.logAssignment(td.matchers.anything()), { times: 0 });
+    });
+  });
+
   it('initializes without an assignment logger', () => {
     const client = offlinePrecomputedInit({ precomputedConfiguration });
 

src/index.ts

@@ -557,7 +557,13 @@ export function getConfigUrl(apiKey: string, baseUrl?: string): URL {
  * @public
  */
 export class EppoPrecomputedJSClient extends EppoPrecomputedClient {
-  public static instance: EppoPrecomputedJSClient;
+  public static instance = new EppoPrecomputedJSClient({
+    precomputedFlagStore: memoryOnlyPrecomputedFlagsStore,
+    subject: {
+      subjectKey: '',
+      subjectAttributes: {},
+    },
+  });
   public static initialized = false;
 
   public getStringAssignment(flagKey: string, defaultValue: string): string {
@@ -609,7 +615,7 @@ export class EppoPrecomputedJSClient extends EppoPrecomputedClient {
 export async function precomputedInit(
   config: IPrecomputedClientConfig,
 ): Promise<EppoPrecomputedClient> {
-  if (EppoPrecomputedJSClient.instance) {
+  if (EppoPrecomputedJSClient.initialized) {
     return EppoPrecomputedJSClient.instance;
   }
 
@@ -764,7 +770,7 @@ export function offlinePrecomputedInit(
 }
 
 function shutdownEppoPrecomputedClient() {
-  if (EppoPrecomputedJSClient.instance && EppoPrecomputedJSClient.initialized) {
+  if (EppoPrecomputedJSClient.initialized) {
     EppoPrecomputedJSClient.instance.stopPolling();
     EppoPrecomputedJSClient.initialized = false;
     applicationLogger.warn('[Eppo SDK] Precomputed client is being re-initialized.');